Closed
Bug 1901057
Opened 13 days ago
Closed 13 days ago
New search config isn't sending the "search-with" ping to glean
Categories
(Firefox :: Search, defect, P1)
Firefox
Search
Tracking
()
RESOLVED
FIXED
128 Branch
People
(Reporter: mkaply, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [sng])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-release+
|
Details | Review |
It appears that with the v2 search rollout, we are not sending the clickUrl to Admarketplace
|
Assignee | |
Comment 1•13 days ago
|
||
|
||
Updated•13 days ago
|
status-firefox127:
--- → affected
tracking-firefox127:
--- → blocking
|
||
Updated•13 days ago
|
Assignee: nobody → standard8
Attachment #9405918 -
Attachment description: WIP: Bug 1901057 - Fix sending the search-with ping with search-config-v2 and remote overrides set. → Bug 1901057 - Fix sending the search-with ping with search-config-v2 and remote overrides set. r?mkaply!
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34c55958f5da Fix sending the search-with ping with search-config-v2 and remote overrides set. r=mkaply,search-reviewers,mcheang
|
|
Assignee | |
Comment 3•13 days ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D212824
|
|
||
Updated•13 days ago
|
Attachment #9405954 -
Flags: approval-mozilla-release?
|
|
||
Comment 4•13 days ago
|
||
release Uplift Approval Request
- User impact if declined: None, search-with attribution will now work correctly.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: QA have steps
- Risk associated with taking this patch: Low
- Explanation of risk level: Fixes a missed addition of a property to a search engine object. Simple addition with null check.
- String changes made/needed: None
- Is Android affected?: no
Flags: qe-verify+
|
|
||
Updated•13 days ago
|
Attachment #9405954 -
Flags: approval-mozilla-release? → approval-mozilla-release+
|
||
Updated•13 days ago
|
status-firefox126:
--- → wontfix
status-firefox128:
--- → affected
status-firefox-esr115:
--- → unaffected
tracking-firefox128:
--- → +
Flags: in-testsuite+
Keywords: regression
|
||
Updated•13 days ago
|
|
||
Comment 6•13 days ago
•
|
||
Verified the search-with glean telemetry ping for search-v2 with the try build :standard8 provided. Ping is recorded using the try build with both v1 and v2 search versions.
We'll redo the verification once 127RC with the fix is available.
Flags: needinfo?(aflorinescu)
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
|
|
Assignee | |
Updated•12 days ago
|
Blocks: search-config-v2
Whiteboard: [sng]
|
||
Updated•12 days ago
|
|
|
||
Comment 8•12 days ago
•
|
||
Verified the search-with glean telemetry ping for search-v2 with 127.0 RC2. Ping is recorded with both v1 and v2 search versions.
Flags: needinfo?(aflorinescu)
You need to log in
before you can comment on or make changes to this bug.
Description
•