Closed Bug 1889462 Opened 3 months ago Closed 9 days ago

crash reporter shown for background tasks

Categories

(Toolkit :: Application Update, defect, P2)

Product:
Toolkit
Component:
Application Update
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: mpohle, Assigned: gsvelto)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fidedi])

Attachments

(1 file)

Bug 1889462 - Do not show the crash reporter client when the main process crashes running a background task, r=nalexander
48 bytes, text/x-phabricator-request
Details | Review

Problem: Under Windows the Crash Reporter can pop "up out of nowhere".

From Nick:

We shouldn't be showing the Crash Reporter from any background task.

This bug is depends on the above linked bug, because it fixes the negative effect, but not necessarily all causes of the problem.

Done for this bug means consequently:

  1. not showing the crash reporter for background tasks.
  2. (optional) integration of other measures to take account for probable other edge-cases.
  3. (optional) integrate the creation of the directory as attempt to mitigate the crash and make the updater more resilient vs. misconfiguration.

With that it remains to be seen if it has potential to fix the linked bug as a whole or if further follow-up bugs are going to be required.

Whiteboard: [fidedi]
Severity: -- → S2
Priority: -- → P2
Assignee: nobody → mpohle
Assignee: mpohle → gsvelto
Status: NEW → ASSIGNED
Attachment #9397203 - Attachment description: Bug 1889462 - crash reporter shown for background tasks, r=nalexander → Bug 1889462 - Do not show the crash reporter client when the main process crashes running a background task, r=nalexander
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b15bd109a6af
Do not show the crash reporter client when the main process crashes running a background task, r=nalexander

Backed out for causing xpcshell failures in test_event_files.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/unit/test_event_files.js | test_main_process_crash - [test_main_process_crash : 35] A single crash event file was seen. - 0 == 1
Flags: needinfo?(gsvelto)

Fixed the patch, landing again.

Flags: needinfo?(gsvelto)
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee228ca76225
Do not show the crash reporter client when the main process crashes running a background task, r=nalexander

https://hg.mozilla.org/mozilla-central/rev/ee228ca76225

Status: ASSIGNED → RESOLVED
Closed: 9 days ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: