Closed Bug 1882089 Opened 4 months ago Closed 7 days ago

Flip the "remote.active-protocols" default value to "1" after the Firefox 128 ESR release

Categories

(Remote Protocol :: Agent, task, P2)

task
Points:
2

Tracking

(firefox129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [webdriver:m11], [wptsync upstream])

Attachments

(2 files, 1 obsolete file)

Right now Firefox enables both the CDP and WebDriver BiDi protocols via the remote.active-protocols preference.

After the 128 ESR release we do not want to have CDP enabled by default anymore, which would require CDP clients to set this preference to 2.

This change would also include writing a blog post most likely on fxdx.dev to explain the strategy behind it. As best this should be send out (at latest) together with the Firefox 127 release to give users time to adapt their client code and CI pipelines.

Blocks: 1882094
Blocks: 1882096
Priority: -- → P2
Whiteboard: [webdriver:backlog]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(hskupin)
Type: defect → task
Flags: needinfo?(hskupin)
Whiteboard: [webdriver:backlog] → [webdriver:m11]
Depends on: 1886759
Points: --- → 2
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9df24a4001c
[remote] Update tests for explictly enabling the CDP protocol if needed. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/ee9ceda9dc3d
[remote] Do not enable CDP protocol by default. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46686 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m11] → [webdriver:m11], [wptsync upstream]
Upstream PR was closed without merging
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0616057daa83
[wdspec] Remove accidentally landed test webdriver/tests/interop/beforeunload_prompt.py. r=webdriver-reviewers,jgraham DONTBUILD
Upstream PR was closed without merging
Pushed by ctuns@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/c094d1257716
[remote] Update tests for explictly enabling the CDP protocol if needed. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/mozilla-central/rev/ccad12fea112
[remote] Do not enable CDP protocol by default. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/mozilla-central/rev/1f6dc95932ad
[wdspec] Remove accidentally landed test webdriver/tests/interop/beforeunload_prompt.py. r=webdriver-reviewers,jgraham a=graft
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Upstream PR merged by moz-wptsync-bot

Backed out for causing wd assertion failures.

Flags: needinfo?(hskupin)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 129 Branch → ---

This can actually be reproduced when running the following mach command:

mach wpt --webdriver-binary=target/debug/geckodriver testing/web-platform/mozilla/tests/webdriver/cdp testing/web-platform/mozilla/tests/webdriver/classic/protocol/

The problematic tests that cause this failure are actually in testing/web-platform/mozilla/tests/webdriver/cdp/debugger_address.py. Note that we explicitly set the remote.active-protocols preference to 2 which means CDP-only enabled. Because the preference is not cleared the classic tests, which follow right after that, where we need WebDriver BiDi enabled start failing because the preference hasn't been reset.

What's interesting is that the Wd3 jobs of the try build that I pushed with the latest fixes did not fail:
https://treeherder.mozilla.org/jobs?repo=try&revision=1b7218c48311684023b81fb8364f3be9f64824a3

Flags: needinfo?(hskupin)
Attachment #9406569 - Attachment is obsolete: true
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bdd1a3d3ce6
[remote] Update tests for explictly enabling the CDP protocol if needed. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/c5d5af7927ef
[remote] Do not enable CDP protocol by default. r=webdriver-reviewers,jdescottes
Status: REOPENED → RESOLVED
Closed: 8 days ago7 days ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: