Closed
Bug 1874406
Opened 5 months ago
Closed 1 month ago
Refactor and optimize event page keepalive implementation
Categories
(WebExtensions :: General, task, P2)
WebExtensions
General
Tracking
(firefox128 fixed)
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: robwu, Assigned: zombie)
References
(Blocks 4 open bugs)
Details
(Whiteboard: [addons-jira])
Attachments
(1 file)
There are a number of issues inherent with the current implementation of event page keep-alive:
- Perf issues (e.g. bug 1830767 & bug 1868960 - both addressed partially).
- Notably the first bug added a TODO blocked on 1844041. With that resolved, we should be able to optimize https://searchfox.org/mozilla-central/rev/69bcb46e73b6a30ee9261cedead161ae7a9a8051/toolkit/components/extensions/ExtensionCommon.sys.mjs#2280-2292
- functional issues (bug 1834683).
We should replace the current timer-based keepalive with sometimes simpler with less overhead, such as maintaining a counter and timestamp. The counter (or Set) would then keep track of the number of outstanding keepalive requests, and avoid suspending a listener. Such a design would make it considerably easier to implement keepalive features (e.g. keeping alive the at startup - bug 1800914, or waitUntil - bug 1781265).
|
||
Updated•5 months ago
|
|
Reporter | |
Updated•5 months ago
|
Severity: -- → N/A
Priority: -- → P2
|
Assignee | |
Comment 1•1 month ago
|
||
|
||
Updated•1 month ago
|
Assignee: nobody → tomica
Status: NEW → ASSIGNED
Pushed by tjovanovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6798b7e7265 Refactor, optimize and cleanup event page idle management r=robwu
Backed out for causing bc failures in browser_opentabs_more.js
Flags: needinfo?(tomica)
Pushed by tjovanovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b966b24e351 Refactor, optimize and cleanup event page idle management r=robwu
|
||
Comment 5•1 month ago
|
||
Backed out for causing xpcshell failures in test_ext_dnr_static_rules_limits.js.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-TIMEOUT | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_dnr_static_rules_limits.js | Test timed out
Pushed by tjovanovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4ee96f483f2 Refactor, optimize and cleanup event page idle management r=robwu
|
||
Comment 7•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
|
|
Assignee | |
Updated•1 month ago
|
Flags: needinfo?(tomica)
You need to log in
before you can comment on or make changes to this bug.
Description
•