Red outline of the find bar when the phrase not found is clipped on the left side
Categories
(Toolkit :: Find Toolbar, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox-esr91 | --- | verified |
| firefox93 | --- | wontfix |
| firefox94 | --- | wontfix |
| firefox95 | --- | verified |
People
(Reporter: cpeterson, Assigned: raquelvargas, Mentored)
References
(Regression)
Details
(Keywords: good-first-bug, regression, Whiteboard: [lang=css])
Attachments
(2 files, 1 obsolete file)
|
9.65 KB,
image/png
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-esr91+
|
Details | Review |
screenshot.png
+++ This bug was initially created as a clone of Bug #1733660 +++
Steps to reproduce
- Open the find bar with Cmd+F or Ctrl+F.
- Search for some string that is not found on the page.
Result
The red outline of the find bar when the phrase not found is clipped on the left side. See the attached screenshot.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
We just need to change this line to outline-offset: -2px; to match these lines.
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
||
Updated•3 years ago
|
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/445b2b503282 Fixes red line of the bar around the left side when not found. r=harry,desktop-theme-reviewers
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
||
Comment 6•3 years ago
|
||
Reproduced this on an affected Nightly build 95.0a1 (2021-10-23) on Win 10x64.
Verified as fixed on Beta 95.0b2 (20211102190739) across following platforms: Win 10x64, macOS 10.15 and Ubuntu 20.04.
|
|
||
Comment 7•3 years ago
|
||
Seems like a pretty trivial polish - did you want to uplift this to ESR?
|
|
||
Comment 8•3 years ago
|
||
Comment on attachment 9247821 [details]
Bug 1737389 - Fixes red line of the bar around the left side when not found. r?harry
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: UI polish with a trivial patch.
- User impact if declined: The border around the findbar will have an inconsistently-sized border.
- Fix Landed on Version: 95
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): One line CSS patch.
- String or UUID changes made by this patch:
|
||
Updated•3 years ago
|
|
|
||
Comment 9•3 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 10•3 years ago
|
||
Verified as fixed on Firefox 91.4.0esr (20211124155212) across the following platforms: Win 10x64, macOS 10.15 and Ubuntu 20.04.
Description
•