Closed Bug 1728656 Opened 3 years ago Closed 11 months ago

Double switch to tab option appears in address bar.

Categories

(Firefox :: Address Bar, defect, P2)

Desktop
All
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- affected
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- fix-optional
firefox94 --- fix-optional

People

(Reporter: muirpablo, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image double.jpg

Description
there is a double "switch to tab" button when there should be only one. since i have only one tab open with a site loaded.

Tested on
Windows 10 64bit, ubuntu 20 and Macos 10.15
Nightly 93.0a1 , Release 91.0.2 , and Beta 92
all affected.

Steps to reproduce

  • create New profile
  • type "moz"
  • click on the option "Get involved" in the suggestions
  • open a second tab
  • type "moz"

Actual results
there are 2 options in the suggestions that are showing a switch to tab.

Expected results
only one option should be showing

note
if you type "moz", 2 will show up
and if you type another letter "mozi", only one shows up

Changing severity to S4

Severity: -- → S4
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regression
Regressed by: 1662167

One has the bookmark title, the other one the history title, there is probably a redirect involved too (the bookmark url redirects to the final one).
This may be a deduplication problem between the first result, that is an adaptive result, and the second result that comes from history.

Another interesting thing here is that a switch to tab entry should probably never use the bookmark title, that just seems confusing if the bookmark redirects, people would think we are suggesting a page that is NOT open. Switch to tab should always match on history title (We may be matching on the wrong title if the page is bookmarked? Should both be matched?) and show history title. This may require a follow-up bug though.

Severity: S4 → S3
Priority: -- → P2

This might've been resolved in a different fix.

Is this issue still reproducible?

Flags: needinfo?(muirpablo)

We verified and we could no longer reproduce this issue on latest builds, solving as RWFM.

Status: NEW → RESOLVED
Closed: 11 months ago
Flags: needinfo?(muirpablo)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: