Cap Windows version in the User-Agent to 10.0
Categories
(Core :: Networking: HTTP, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
In bug 1679929, we're capping the version number reported for macOS. I suggest we also cap the Windows version to 10.0. There isn't a change in sight to the version number reported by Windows, which means that if it ever changes, the potential for disruption to user agent sniffing is going to be large.
If we cap it to 10.0 now, we can then evaluate whether we want to change the Web-visible value if the OS-reported value ever changes instead of experiencing what happened with macOS: The OS API changing the value and us having to react to the breakage.
|
Assignee | |
Comment 1•3 years ago
|
||
No tests, because proper testing would need CI with Windows reporting a a version above 10.0.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Comment 3•3 years ago
|
||
Even if Windows changes the version number, the reported version number will not change until we update supportedOSes in the manifest, I guess. Nevertheless I totally agree with you. We don't have to rely on operating system's compatibility shim.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
I ran the test build on Windows 10 and Windows 7, and it didn't interfere with the pre-existing functionality. (I.e. reported 10.0 and 6.1, respectively, both via HTTP and navigator).
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b60746765d3 Cap the Windows version in the User-Agent to 10.0. r=cpeterson
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Description
•