Closed Bug 1583903 Opened 5 years ago Closed 13 days ago

[Inactive CSS] Display a warning when properties only applying to replaced elements are used on non-replaced elements

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

enhancement

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: miker, Assigned: sebo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [importance-6.7%])

Attachments

(1 file)

Main file:
devtools/server/actors/utils/inactive-property-helper.js

invalidProperties: [
"crop",
"object-fit",
"object-position",
]

inactive-css-only-replaced-elements = <strong>{ $property }</strong> has no effect on this element since it can only be applied to replaced elements.

inactive-css-only-replaced-elements-fix = Ensure you are adding the property to a replaced element. { learn-more }

Severity: normal → S3

As far as I know, there is no crop property. There was one defined a long time ago in CSS Content 3, though it got dropped at some point. So I guess we're left with object-fit and object-position.

Sebastian

Summary: [Inactive CSS] Display a warning when 'crop' etc. are used on non-replaced elements → [Inactive CSS] Display a warning when properties only applying to replaced elements are used on non-replaced elements
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Attachment #9405384 - Attachment description: Bug 1583903 - [devtools] Handle properties only applying to replacd elements in inactive CSS. r=#devtools-reviewers. → Bug 1583903 - [devtools] Handle properties only applying to replaced elements in inactive CSS. r=#devtools-reviewers.
Pushed by sebastianzartner@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b280eb51e7f2
[devtools] Handle properties only applying to replaced elements in inactive CSS. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe.
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: