Get rid of most extraneous LWT gunk
Categories
(Toolkit :: Add-ons Manager, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(9 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
There's still a lot of static theme and built-in theme stuff that depends on the LightweightThemeManager infrastructure that needs some care to get rid of. But there's also a lot of extraneous crap that touches LightweightThemeManager where it should just use AddonManager, and the LWT web install stuff, which we can get rid of much more easily, and sooner.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
|
Assignee | |
Comment 9•5 years ago
|
||
|
||
Comment 10•5 years ago
|
||
Does this get rid of theme switching from customize entirely? It would be pretty weird to have recommendations (A Web Browser Renaissance, et al), but not have installed themes shown there (especially because there is a header labeled "My Themes" containing the built in themes... which aren't exactly "mine").
I will say, I really like the preview as well in that dropdown as well - it feels super discoverable.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 11•5 years ago
|
||
(In reply to Asif Youssuff from comment #10)
Does this get rid of theme switching from customize entirely?
No, although that's planned in bug 1515211.
|
|
Assignee | |
Comment 12•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e711fcd0a02d952ac24742e8c34a369cc292cef4 Bug 1525511: Part 1 - Remove LWT install gunk. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/5cb9e990d8e31a0bad351693cfa49378bf1d4c0d Bug 1525511: Part 2a - Delete theme preview gunk. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/85e270253e04bda2ff0a8d22543aec2b537345a5 Bug 1525511: Part 2b - Delete recommended theme gunk. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/7262fc6d3c831f0182f3622ad6a2661078861e03 Bug 1525511: Part 2c - Stop using LightweightThemeManager for customize mode themes menu. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/28358411c6b3818700b2c5ed8c5e97a0c8811a81 Bug 1525511: Part 2d - Stop using LightweightThemeManager for in CustomizableUI. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/1b6a747042877e449de37d6f7968416045021f2c Bug 1525511: Part 3 - Get rid of theme preview gunk in UITour. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/0467cc193a741940e9ee48a06740c821bb469b20 Bug 1525511: Part 4 - Get rid of persona gunk in Telemetry. r=aswan,chutten https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c0bc33eea6788070c1886ce6ad95c4396fff4c Bug 1525511: Part 5 - Get rid of most LWTManager gunk in tests. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/ce04183ab703536f3c8957b93f13b41da10730ff Bug 1525511: Part 6 - Get rid of persona sync gunk. r=aswan
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e711fcd0a02d
https://hg.mozilla.org/mozilla-central/rev/5cb9e990d8e3
https://hg.mozilla.org/mozilla-central/rev/85e270253e04
https://hg.mozilla.org/mozilla-central/rev/7262fc6d3c83
https://hg.mozilla.org/mozilla-central/rev/28358411c6b3
https://hg.mozilla.org/mozilla-central/rev/1b6a74704287
https://hg.mozilla.org/mozilla-central/rev/0467cc193a74
https://hg.mozilla.org/mozilla-central/rev/d9c0bc33eea6
https://hg.mozilla.org/mozilla-central/rev/ce04183ab703
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Description
•