Ryan VanderMeulen [:RyanVM] Reporter
	Description • 7 years ago

+++ This bug was initially created as a clone of Bug #1397441 +++

Confirm and patch security/manager/ssl/StaticHPKPins.h and security/manager/ssl/nsSTSPreloadList.inc in 58 to have sufficient lifetime on the preloaded HPKP and STS pins.

Going off past precedents, we'll want an expiration date of around 2018-05-01 to coincide with the release of Firefox 60.

	Marcia Knous [:marcia]
	Comment 1 • 7 years ago

Tracking 58+.

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 2 • 7 years ago

We should get this landed on Beta soon. Can you put up a patch, David?

	Dana Keeler (she/her) (use needinfo) [:keeler] Assignee
	Comment 3 • 7 years ago

Calendar says May 8th right now, so that's what I went with.

	J.C. Jones [:jcj] (he/they)
	Comment 4 • 7 years ago

Comment on attachment 8939681 [details] [diff] [review]
patch

Review of attachment 8939681 [details] [diff] [review]:
-----------------------------------------------------------------

Confirmed, that timestamp is Firefox 58 + 2 releases = Firefox 60.

	Dana Keeler (she/her) (use needinfo) [:keeler] Assignee
	Comment 5 • 7 years ago

Comment on attachment 8939681 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: built-in pinning and hsts information would expire before the next update
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: this just increases the expiration time of these data structures - we've done it a number of times now and we're fairly confident in the process
[String changes made/needed]: none

	Gerry Chang [:gchang]
	Comment 6 • 7 years ago

Comment on attachment 8939681 [details] [diff] [review]
patch

Important fix. Beta58+.

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 7 • 7 years ago
uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/70846c567017