Franziskus Kiefer [:franziskus] Assignee
	Description • 7 years ago

Addition in drbg.c for the internal state V doesn't correctly carry bits over.

This was independently discovered by Vladimir Klebanov (Karlsruher Institute of Technology) and myself.

	Franziskus Kiefer [:franziskus] Assignee
	Comment 1 • 7 years ago

Adding NIST KAT tests and fixing the carry error.

https://hg.mozilla.org/projects/nss/rev/6fafb8fd9ff4ea82725e5ade4453e205ecc48651

	Ryan VanderMeulen [:RyanVM]
	Comment 2 • 7 years ago

Talked to Franziskus on IRC about this. It's likely to get backported to 3.30 as well before that goes final (which will then find its way into Fx54). It's less clear whether it'll get backported to 3.29 (Fx53) or 3.28 (ESR52) at this point.

	Kai Engert (:KaiE:)
	Comment 3 • 7 years ago

I see this was checked in for 3.30:
https://hg.mozilla.org/projects/nss/rev/a08fb7c8542c

Changing NSS target milestone.

	Tim Taubert [:ttaubert] (inactive)
	Comment 4 • 7 years ago

Landed on the NSS 3.28.4 branch:

https://hg.mozilla.org/projects/nss/rev/7248d38b76e5

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 5 • 7 years ago

This should be fixed in beta by the NSS upgrade in bug 1353740 (for the beta 10 build tomorrow)