Stanislav Melnychek Reporter
	Description • 8 years ago

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce:

When confirmation geolocation popup is open and you try to change option from select list there is nothing happens in first time.


Actual results:

Option the same as it was.


Expected results:

It should change option from select after change it

	YF (Yang)
	Comment 1 • 8 years ago
regression-window

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8883360b1edb&tochange=5811efc11011

Suspect:
Florian Quèze — Bug 991202 - The event callback of popup notifications should have a way to prevent the panel from showing, r=felipe.

	YF (Yang)
	Comment 2 • 8 years ago

status-firefox53=unaffected is due to bug 1282768 changed the form.

	Andrew Overholt [:overholt]
	Comment 3 • 8 years ago

Florian, do you think we can get a fix that's uplift-able to, say, 52 ESR (I only ask about ESR because of the non-e10s aspect here)?

	Florian Quèze [:florian]
	Comment 4 • 8 years ago

(In reply to Andrew Overholt [:overholt] from comment #3)
> Florian, do you think we can get a fix that's uplift-able to, say, 52 ESR (I
> only ask about ESR because of the non-e10s aspect here)?

I can't reproduce (I tried on 50.1.0 on OS X with e10s disabled). Is this Windows-only?

Also, I don't see how this relates to bug 991202, which was a pretty self-contained patch, only adding a simple feature to PopupNotifications.jsm. Can mozregression provide a more specific regression range?

	YF (Yang)
	Comment 5 • 8 years ago

(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> (In reply to Andrew Overholt [:overholt] from comment #3)
> > Florian, do you think we can get a fix that's uplift-able to, say, 52 ESR (I
> > only ask about ESR because of the non-e10s aspect here)?
> 
> I can't reproduce (I tried on 50.1.0 on OS X with e10s disabled). Is this
> Windows-only?

Yes, I reproduce it on Windows 10.

> Also, I don't see how this relates to bug 991202, which was a pretty
> self-contained patch, only adding a simple feature to
> PopupNotifications.jsm. Can mozregression provide a more specific regression
> range?

I could not get a more accurate range because it was stale.

	Andrew Overholt [:overholt]
	Comment 6 • 8 years ago

Given comment 5, any chance you could take a look on a Windows machine, Florian?

	Florian Quèze [:florian]
	Comment 7 • 8 years ago

bisecting on Windows gives me this range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b17e7747d3fb&tochange=986ef444a8bb

I would say bug 1079303 is the most likely suspect.

	:Gijs (he/him)
	Comment 8 • 8 years ago

I can try to look at this when I have access to my Windows machine again (likely Thursday).

However, at a guess, I expect this has to do with popup rollup, though it's not clear to me why it would have been affected in any way by my patches from bug 1079303. If those patches did change something, I would expect that you would be able to reproduce the same issue before my patches when using another (animating?) popup like the main menu popup. Florian, is that the case?

On OS X, the popup rolls up as soon as you click the select dropdown. Is that not what happens on Windows? Florian?

	Florian Quèze [:florian]
	Comment 9 • 8 years ago

(In reply to :Gijs from comment #8)

> If those patches did change something, I would expect that
> you would be able to reproduce the same issue before my patches when using
> another (animating?) popup like the main menu popup. Florian, is that the
> case?

I haven't tried on builds before your patches, but I've just verified that the bug can be reproduced on both 52 and the current trunk with the control center panel. It reproduces with the main menu popup too.

> On OS X, the popup rolls up as soon as you click the select dropdown. Is
> that not what happens on Windows? Florian?

I can't reproduce on OS X. I would guess there's something platform specific in the way the <select> element's popup captures events, but it's just a random guess.

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 8 years ago

Based on comment 9, it sounds like 53/54 are in fact affected as well.

	Andrew Overholt [:overholt]
	Comment 11 • 7 years ago

FWIW I cannot reproduce in nightly on Windows 10 with the attached index.html (https://bugzilla.mozilla.org/attachment.cgi?id=8820290) but that could be because of the new geolocation doorhanger design. I haven't tried the control center panel or the main menu popup that Florian references in comment 9.

	Julien Cristau [:jcristau]
	Comment 12 • 7 years ago

Too late for firefox 52, mass-wontfix.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 13 • 7 years ago

Really unclear if this still reproduces and in what way. Andrei can your team check which branches may be affected (for Windows only)?  Sounds like it may be fixed in 55 but maybe not in 54 and 52esr. 

It seems unlikely this could have been broken since 50! I'm hoping that it's fixed already.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 14 • 7 years ago

Also, no rush on this, I'm not considering it a blocker for 53, this is just to test fairly soon for 54 (during 54 beta)

	Mihai Boldan, Desktop QA [:mboldan]
	Comment 15 • 7 years ago

I've investigated this bug and noticed that the issue is not reproducible on builds that contain the new design for the geolocation confirmation pop-up. 

This bug was fixed along the way by one of the bugs from this pushlog, generated by mozregression: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=abecacadf9d3006029eb2208445521f495e80a70&tochange=2e3bef583561c4812e6093a5ec639b1a58d0ab18
  
Last good revision: abecacadf9d3006029eb2208445521f495e80a70
First bad revision: 2e3bef583561c4812e6093a5ec639b1a58d0ab18

The issue is still reproducible on Firefox 52.1.0 ESR.

I confirm that the issue is no longer reproducible on Firefox 54.0b1, or on Firefox 55.0a1 (2017-04-20).

Tests were performed using STR from Comment 0, with e10s enabled and disabled, under Windows 10x64, Ubuntu 16.04x64, Mac OS X 10.12.4.

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 16 • 7 years ago

We may want to consider this for ESR52 uplift.

	Julien Cristau [:jcristau]
	Comment 17 • 7 years ago

I doubt we'll go back and fix this in esr52, especially if the fix came in the form of a design change for the doorhanger.