Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] Tor DNS issue #13527

Closed
diracdeltas opened this issue Jan 12, 2021 · 1 comment
Closed

[hackerone] Tor DNS issue #13527

diracdeltas opened this issue Jan 12, 2021 · 1 comment
Assignees
@diracdeltas @darkdh
Labels
OS/Desktop QA Pass-Win64 QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include security
Projects
Tor and Private Windows General
Milestone
1.20.x - Release #2

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 12, 2021 •
edited

https://hackerone.com/reports/1077022

related: #4257. it appears this was a known issue at least in the muon days. unclear if it was ever fixed in brave-core.

UPDATE: cause was cname adblocking, so this is a regression, not an earlier issue.
@diracdeltas diracdeltas self-assigned this Jan 12, 2021
@jumde jumde added this to Untriaged Backlog in Security & Privacy via automation Jan 15, 2021
@jumde jumde added this to Untriaged in Tor and Private Windows via automation Jan 15, 2021
@jumde jumde removed this from Untriaged Backlog in Security & Privacy Jan 15, 2021
@darkdh darkdh self-assigned this Jan 27, 2021
@darkdh darkdh moved this from Untriaged to In progress in Tor and Private Windows Jan 27, 2021
@darkdh darkdh mentioned this issue Feb 2, 2021
Merged
5 of 23 tasks complete
Tor and Private Windows automation moved this from In progress to Completed Feb 4, 2021
@darkdh darkdh added this to the 1.22.x - Nightly milestone Feb 4, 2021
@rebron rebron added this to Completed in General Feb 9, 2021
@brave-builds brave-builds mentioned this issue Feb 10, 2021
Merged
4 of 7 tasks complete
@mcgroarty mcgroarty mentioned this issue Feb 19, 2021
Open
@bbondy bbondy mentioned this issue Feb 19, 2021
Merged
4 of 7 tasks complete
@diracdeltas diracdeltas mentioned this issue Feb 19, 2021
Closed
@LaurenWags LaurenWags mentioned this issue Feb 19, 2021
Closed
@stephendonner
Copy link
Collaborator

@stephendonner stephendonner commented Feb 19, 2021 •
edited

Verified FIXED on 1.20.108 using the testplan in brave/brave-core#7769, on:

Brave | 1.20.108 Chromium: 88.0.4324.182 (Official Build) (x86_64)
Revision | 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS
macOS Version 11.2.1 (Build 20D74)

Brave | 1.20.108 Chromium: 88.0.4324.182 (Official Build) (64-bit)
Revision73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS | Windows 10 OS Version 2009 (Build 21318.1000)

Verified that in both the DoH off and DoH enabled cases, in Private with Tor tabs, I didn't see DNS-lookup entries for tools.ietf.org via the DNS filter in Wireshark.

macOS 11.2.1 (Big Sur)

Screen Shot 2021-02-19 at 2 57 28 PM

Screen Shot 2021-02-19 at 2 55 27 PM

Windows 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

@darkdh darkdh

Labels
OS/Desktop QA Pass-Win64 QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include security
Projects
Tor and Private Windows
  
Completed
General
  
Completed
Milestone
1.20.x - Release #2
Linked pull requests

Successfully merging a pull request may close this issue.

Fix Tor dns leak
4 participants
@stephendonner @diracdeltas @kjozwiak @darkdh