Page MenuHomePhabricator

Alignment problem in link hovering
Closed, ResolvedPublic1 Estimated Story Points

Description

When I hover over a link, the link is not always "activated" when I hover over the link.

My device:
Windows 10 pro, newest Firefox

Test here (make sure to enable the reference previews in beta features.

A video to demonstrate the bug: https://www.youtube.com/watch?v=iCFRwUgNQMg

Event Timeline

Bug confirmed with Windows 7 and chrome 89.0.4389.82. It seems that if the link is in the bottom line then it is not activated when mouse cursor is hovered over the link. Link cannot be clicked either.

Lena_WMDE set the point value for this task to 2.Mar 18 2021, 2:58 PM

Change 673302 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/Popups@master] Hide reference preview footers when they are empty

https://gerrit.wikimedia.org/r/673302

Change 673525 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/Popups@master] Fix popup footer covering reference content

https://gerrit.wikimedia.org/r/673525

Change 673302 abandoned by Andrew-WMDE:
[mediawiki/extensions/Popups@master] Hide reference preview footers when they are empty

Reason:
Abandoned in favor of I66313a282f24fd45804574577d8e071572de92b6

https://gerrit.wikimedia.org/r/673302

This is actually an issue with all popup types. Here is a page preview where I made the rectangle that covers the content visible.

Screenshot from 2021-03-26 16-49-36.png (422×407 px, 184 KB)

It's just not so much notable on the other popup types because you typically don't click them. Except you can, e.g. when you want to close this popup. Try to slowly move the mouse over this popup. You will notice that the mouse cursor changes on the last row, and clicking in this area doesn't do anything.

I updated the patch accordingly.

Change 673525 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix popup footer covering reference content

https://gerrit.wikimedia.org/r/673525

Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-03-31 board.

The problem appeared again today:

Change 709488 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Fix popups footer covering clickable content

https://gerrit.wikimedia.org/r/709488

I can confirm this. The reason is that the previous patch https://gerrit.wikimedia.org/r/673525 was only a partial fix. It helped already. In the example shown in the video the top half of the link is already clickable, but the bottom half still isn't. Here is the problematic area highlighted:

Screenshot from 2021-08-02 16-34-37.png (171×357 px, 30 KB)

I found a better fix.

thiemowmde changed the point value for this task from 2 to 1.

Change 709488 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix popups footer covering clickable content

https://gerrit.wikimedia.org/r/709488