Page MenuHomePhabricator
Create Task
Maniphest T242311

Drop Revision::loadFromId(), deprecated and unused
Closed, ResolvedPublic
Actions

Description

Revision::loadFromId(), deprecated in 1.31, can be removed.
It has no remaining callers. See code search (note that User::loadFromId also exists; the only caller for the function on a Revision object is in the test for the function)

Details

SubjectRepoBranchLines +/-
Add release notes for I0c8fe834dmediawiki/coremaster+2 -0
Remove Revision::loadFromId(), deprecated and unusedmediawiki/coremaster+0 -61
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jan 9 2020, 4:10 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 9 2020, 4:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Jan 9 2020, 4:12 AM
DannyS712 mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Jan 9 2020, 4:23 AM
Aklapper added a project: MediaWiki-Core-Revision-backend.Jan 12 2020, 5:13 AM
Aklapper updated the task description. (Show Details)
Krinkle moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.Feb 14 2020, 6:48 PM
gerritbot added a comment.Feb 21 2020, 5:01 AM

Change 573846 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove Revision::loadFromId(), deprecated and unused

https://gerrit.wikimedia.org/r/573846

gerritbot added a project: Patch-For-Review.Feb 21 2020, 5:01 AM
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Feb 21 2020, 5:03 AM
gerritbot added a comment.Mar 3 2020, 11:49 AM

Change 573846 merged by jenkins-bot:
[mediawiki/core@master] Remove Revision::loadFromId(), deprecated and unused

https://gerrit.wikimedia.org/r/573846

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Mar 3 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 3 2020, 12:10 PM
gerritbot added a comment.Mar 3 2020, 3:00 PM

Change 576360 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add release notes for I0c8fe834d

https://gerrit.wikimedia.org/r/576360

gerritbot added a project: Patch-For-Review.Mar 3 2020, 3:00 PM
gerritbot added a comment.Mar 3 2020, 4:11 PM

Change 576360 merged by jenkins-bot:
[mediawiki/core@master] Add release notes for I0c8fe834d

https://gerrit.wikimedia.org/r/576360

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Mar 3 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 3 2020, 5:10 PM
DannyS712 closed this task as Resolved.Mar 3 2020, 5:31 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Mar 4 2020, 7:54 AM
Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits