New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber.subscribe() does not surface BaseException() encountered in the user provided callback function to the calling code #1107

Closed

mukund-ananthu opened this issue Mar 5, 2024 · 0 comments · Fixed by #1108

Assignees

Labels

Contributor

mukund-ananthu commented Mar 5, 2024

Currently, the behavior of the library is to catch Exception() when encountered in the user provided callback, surface it to the calling code and shut down the client.

python-pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py

Line 127 in 0562d23

except Exception as exc:

However, for BaseException() encountered in the user provided callback, the BaseException() is not surfaced to the calling code and the client is not shut down.
Make the behavior of the client when BaseException() is encountered consistent with the behavior of the client when Exception() is encountered.

mukund-ananthu self-assigned this

product-auto-label bot added the api: pubsub label

mukund-ananthu mentioned this issue

fix: Catch and surface BaseException() #1108

Merged

mukund-ananthu closed this as completed in #1108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment