diff options
| author | Eric Biggers <[email protected]> | 2023-11-06 20:44:34 -0800 |
|---|---|---|
| committer | Jaegeuk Kim <[email protected]> | 2023-11-17 09:30:54 -0800 |
| commit | e26b6d39270f5eab0087453d9b544189a38c8564 (patch) | |
| tree | 58f03f7074282cd9aa88a87944b10590223f9833 | |
| parent | 5e4166461cf66a26f925011d90017da74e410747 (diff) | |
| download | linux-e26b6d39270f5eab0087453d9b544189a38c8564.tar.gz | |
f2fs: explicitly null-terminate the xattr list
When setting an xattr, explicitly null-terminate the xattr list. This
eliminates the fragile assumption that the unused xattr space is always
zeroed.
Signed-off-by: Eric Biggers <[email protected]>
Reviewed-by: Chao Yu <[email protected]>
Signed-off-by: Jaegeuk Kim <[email protected]>
| -rw-r--r-- | fs/f2fs/xattr.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 47e88b4d4e7d01..a8fc2cac687995 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -754,6 +754,12 @@ retry: memcpy(pval, value, size); last->e_value_size = cpu_to_le16(size); new_hsize += newsize; + /* + * Explicitly add the null terminator. The unused xattr space + * is supposed to always be zeroed, which would make this + * unnecessary, but don't depend on that. + */ + *(u32 *)((u8 *)last + newsize) = 0; } error = write_all_xattrs(inode, new_hsize, base_addr, ipage); |