Publish DEPS for Chromium 56.0.2924.10
Incrementing VERSION to 56.0.2924.10
Cr-Commit-Position: refs/branch-heads/2924@{#148}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge "SELECT element: Commit a provisional OPTION selection on blur." to M56
PopupMenuImpl::hide(), which is called on blur, should have same behavior as
PopupMenuImpl::closePopup(), which is called on canceling a popup.
Also, this CL removes hidePopup() call on 'disabled' attribute change because
enabling 'disabled' attribute will remove the focus, and move blur event handling
from menuListDefaultEventHandler() to dispatchBlurEvent() because
menuListDefaultEventHandler() isn't called if the element is disabled.
BUG=659585
Review-Url: https://codereview.chromium.org/2522383002
Cr-Commit-Position: refs/heads/master@{#434395}
(cherry picked from commit b9ec42c0abbf77c9228f0d97ce261fb16b356094)
Review URL: https://codereview.chromium.org/2537573003 .
Cr-Commit-Position: refs/branch-heads/2924@{#147}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Update text layout in system menu.
Removes the vertical padding between multi label rows and moves the date
text in the system info row 4 dp to the right.
BUG=668333, 667944
Review-Url: https://codereview.chromium.org/2531713002
Cr-Commit-Position: refs/heads/master@{#434416}
(cherry picked from commit 445aa4a62b3f74e3276bfd83bceaf9c4699a734f)
Review URL: https://codereview.chromium.org/2530413004 .
Cr-Commit-Position: refs/branch-heads/2924@{#146}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Made the ink drop blue for system menu buttons with blue icons.
This fixes a regression caused by
https://codereview.chromium.org/2501693005/.
A small number of system menu buttons have blue icons and the ink drop
color should match this.
BUG=668292
Review-Url: https://codereview.chromium.org/2528853002
Cr-Commit-Position: refs/heads/master@{#434405}
(cherry picked from commit 2be8bbde136092f9565f11002fc65828143895af)
Review URL: https://codereview.chromium.org/2536963002 .
Cr-Commit-Position: refs/branch-heads/2924@{#145}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Hide Launcher app search box when empty
BUG=661380
TEST=Open launcher, type a search that returns no app results. The
horizontal box that usually contains app results should be hidden.
Review-Url: https://codereview.chromium.org/2473033002
Cr-Commit-Position: refs/heads/master@{#433686}
(cherry picked from commit 32247f5271fd583a683bc8dc2e4c07ce3cf72b85)
Review URL: https://codereview.chromium.org/2536053002 .
Cr-Commit-Position: refs/branch-heads/2924@{#144}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix separator position in status tray area in RTL system
In RTL mode, the separator between status tray and next item is
missing and an extra separator is shown at the end. This Cl fixes
separator positions in RTL system.
TEST=Manual
- Checked separator position in system tray area in RTL system
while the shelf is horizontally and vertically aligned.
- Check if separator satisfies the MD spec by measuring its
size using GIMP.
BUG=665043
Review-Url: https://codereview.chromium.org/2508363002
Cr-Commit-Position: refs/heads/master@{#434363}
(cherry picked from commit 571de9f774ee1cb11d78cc04f8c51c5805e5d429)
Review URL: https://codereview.chromium.org/2539543003 .
Cr-Commit-Position: refs/branch-heads/2924@{#143}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Changes font weight and color for sub-section header rows
This CL uses TrayPopupItemStyle to set up fonts and colors on
section header rows in Network and VPN detailed pages in system menu.
BUG=663451
TEST=Manual visual inspection
Review-Url: https://codereview.chromium.org/2527783003
Cr-Commit-Position: refs/heads/master@{#434334}
(cherry picked from commit 772863e3a0ce451e26400654797c3ef517f0c58b)
Review URL: https://codereview.chromium.org/2539633002 .
Cr-Commit-Position: refs/branch-heads/2924@{#142}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Fix system menu buttons to not show an ink drop when disabled.
The InkDropGestureHandler was not respecting the host views enabled flag and
thus was triggering ink drop animations on disabled buttons. Furthermore many
system menu buttons were being disabled via
CustomButton::SetState(STATE_DISABLED) which is a Button specific property and
is not visible to the InkDropGestureHandler.
This CL fixes the InkDropGestureHandler to respect View::enabled_ and updates
many system menu buttons to use View::SetEnabeled(false) instead of
CustomButton::SetState(STATE_DISABLED).
TEST=views_unittests --gtest_filter=InkDropHostViewTest.GestureEventsDontTriggerInkDropsWhenHostIsDisabled
BUG=668240
Review-Url: https://codereview.chromium.org/2530603002
Cr-Commit-Position: refs/heads/master@{#434333}
(cherry picked from commit b1d158120453d93836e7f13d309329aeb20a1d85)
Review URL: https://codereview.chromium.org/2539613002 .
Cr-Commit-Position: refs/branch-heads/2924@{#141}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
cc: Force update tile priorities for pending tree tiling set on commit.
Forcing |UpdateTilePriorities| for pending tree tiling sets to prevent
checkerboarding for cases where compositor is heavily pipelined. In
these cases it's possible for a commit to happen after |PrepareTiles| is
called during draw. The commit then skips |PrepareTiles| and activates
the pending tree causing checkerboarding.
|PrepareTiles| is skipped because of a |PictureLayerTilingSet| early out
optimization that relies on frame time and viewport to avoid updating
tiles. To fix this the tile priorities are always updated on commit.
BUG=664007
[email protected]
TEST=unittest + manual testing on samus
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2529533002
Cr-Commit-Position: refs/heads/master@{#434236}
(cherry picked from commit 53fabb1f55e8db09a8bd53ca7af11c2c96667af3)
Review URL: https://codereview.chromium.org/2538593002 .
Cr-Commit-Position: refs/branch-heads/2924@{#140}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add round rect mask to overflow button's ripple
BUG=667889
TEST=manual
Review-Url: https://codereview.chromium.org/2524183002
Cr-Commit-Position: refs/heads/master@{#434305}
(cherry picked from commit 6cc1f1f6a057f9870c82e8410169df35a6e60176)
Review URL: https://codereview.chromium.org/2538583002 .
Cr-Commit-Position: refs/branch-heads/2924@{#139}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Show system menu when user taps on the time in status tray
Tapping anywhere on the status tray should bring up system menu. That
was not the case for the part that shows time.
BUG=666453
TEST=manual
Review-Url: https://codereview.chromium.org/2530723002
Cr-Commit-Position: refs/heads/master@{#434304}
(cherry picked from commit 26cbf70015b7d26fcd0ce0dccea8f6d1e4966e97)
Review URL: https://codereview.chromium.org/2533113002 .
Cr-Commit-Position: refs/branch-heads/2924@{#138}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge to M56: Report redirect UMA in offline interceptor
BUG=666963
Review-Url: https://codereview.chromium.org/2507293006
Cr-Commit-Position: refs/heads/master@{#434029}
(cherry picked from commit 48ea10d8835e13336cf03c243b938bcb133dba49)
Review URL: https://codereview.chromium.org/2521393003 .
Cr-Commit-Position: refs/branch-heads/2924@{#137}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Adds Wi-Fi network status indicators in system menu
BUG=663129
Test=Connect to a Wi-Fi network.
Verify that connected network has "Connected" indicator.
Verify that connected network appears at the top of the list.
Review-Url: https://codereview.chromium.org/2517953006
Cr-Commit-Position: refs/heads/master@{#434283}
(cherry picked from commit bd890d24dd4bb15a15e891d4fdb273dc330d7f2a)
Review URL: https://codereview.chromium.org/2532053003 .
Cr-Commit-Position: refs/branch-heads/2924@{#136}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Update Caps Lock to changes text theme based on Native Theme
The Caps Lock now updates its theme based on the UI theme,
not the system native theme.
BUG=663207
Review-Url: https://codereview.chromium.org/2522803003
Cr-Commit-Position: refs/heads/master@{#434181}
(cherry picked from commit 4d14216654eb9a825efbb335f232af55b5c84e5a)
Review URL: https://codereview.chromium.org/2531163003 .
Cr-Commit-Position: refs/branch-heads/2924@{#135}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add virtual keyboard item into opt-in IME menu.
The 'Smart deploy toggle' is always hidden in opt-in IME menu. We should show/hide it based on the vr and devices state.
Make ImeMenuTray listens on the virtual keyboard state to show the toggle.
Currently the ImeMenuBubble doesn't support update UI. So if there's state change (which leads to UI change) of the VK, just hide the bubble.
BUG=668013
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2474843002
Cr-Commit-Position: refs/heads/master@{#434127}
(cherry picked from commit 1fb9e7720d5a4ddaef6ce257f4d252a831bea688)
Review URL: https://codereview.chromium.org/2536003002 .
Cr-Commit-Position: refs/branch-heads/2924@{#134}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Set the right ChromeVox spoken feedback for IME row.
As described in the bug, fixed the broken ChromeVox spoken feedback for IME row:
Output "<IME name>", followed by "check box", followed by either "checked" or "not checked" depending on the checked state of the row.
BUG=666526
TEST=Verified on local build.
Review-Url: https://codereview.chromium.org/2518863002
Cr-Commit-Position: refs/heads/master@{#434102}
(cherry picked from commit ac9efef6c1818fcfb0ea5fdce3015afdd19787ed)
Review URL: https://codereview.chromium.org/2538553002 .
Cr-Commit-Position: refs/branch-heads/2924@{#133}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Restore original opacity when exiting overview
BUG=667526
[email protected]
TEST=Updated WindowSelectorTest.BasicTextFiltering
Review-Url: https://codereview.chromium.org/2525753002
Cr-Commit-Position: refs/heads/master@{#434025}
(cherry picked from commit 355b36934b8f321a7970679f9a13fa8768a1c384)
Review URL: https://codereview.chromium.org/2532273002 .
Cr-Commit-Position: refs/branch-heads/2924@{#132}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Android] Fix timing issue in enabling/disabling printing.
There are a couple timing issues in the previous
implementation of the code that enables/disables the print
activity that is accessible via share.
1.) Multiple calls to enablePrintShareOption could result
in the second call having the callback run immediately
without the component first being enabled (since it
would have been triggered in an AsyncTask in the first
call).
2.) Back to back enable/disable calls could result in
unpredictable execution ordering as they run their
tasks on the thread pool instead of in serial. Because
the initial UI is only shown after the first callback is
run, this would require a show, followed by a hide, followed
by a show where the task enqueued by the hide is run after
the enabling call in the second show.
To work around this (and due to the expected usage pattern of
this class), just wait for the task to be run in either of these
states to avoid this being possible. It would also be possible
to use the SERIAL executor, but that might end up slowing down
the default share flow where we don't expect this interleaving
issue.
BUG=649453,664486
Review URL: https://codereview.chromium.org/2535803003 .
Review-Url: https://codereview.chromium.org/2523873003
Cr-Original-Commit-Position: refs/heads/master@{#434676}
Cr-Commit-Position: refs/branch-heads/2924@{#131}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Linux Aura: Fix overlay shadows on notifications
>Linux Aura got support for translucent windows in CL:
>https://chromium.googlesource.com/chromium/src.git/+/62ba78ffcdf525eb9ed640724e640fcf22fbbf87
>
>Some Chrome widgets used a TRANSLUCENT_WINDOW opacity for widgets that
>fade in or out, but that don't actually have an alpha mask. This was
>to support a limitation on MS Windows where windows must be
>translucent to fade.
>
>However, most Linux window managers only draw shadows on opaque
>windows: that is, windows that do not have an alpha channel. Windows
>that fade in or out may still have shadows since opacity is set as a
>property of the toplevel window.
>
>Therefore, the solution is to use INFER_OPACITY for fading widgets so
>it will work across platforms. TRANSLUCENT_WINDOW should only be used
>on widgets that have alpha masks.
>
>BUG=640170
>
>[email protected]
>
>patch from issue 2398203002 at patchset 40001
>(http://crrev.com/2398203002#ps40001)
>
NOPRESUBMIT=true
NOTRY=true
BUG=640170
[email protected]
Review-Url: https://codereview.chromium.org/2540463002
Cr-Commit-Position: refs/branch-heads/2924@{#130}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Remove merge artifact from 56f7c1e4c916655dbab30a49c1cea63b89d3f248.
In 56f7c1e4c916655dbab30a49c1cea63b89d3f248 I incorrectly added a test
exception from master (not my merged patch). Removing this.
TBR=schenney
BUG=666147
TEST=None
Review URL: https://codereview.chromium.org/2535073002 .
Cr-Commit-Position: refs/branch-heads/2924@{#129}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Reset settings button when update the list view.
We need to reset the settings button object when updating the IME detailed view, otherwise there may has memory leak, and checking if(settings_button_) could be true but the IME view is updated without drawing the settings button.
BUG=667105
TEST=Verified on Clapper.
Review-Url: https://codereview.chromium.org/2521443002
Cr-Commit-Position: refs/heads/master@{#434083}
(cherry picked from commit 4ac84d7c1ef8eb9c8d1ab59608975de1db3c7821)
Review URL: https://codereview.chromium.org/2533793004 .
Cr-Commit-Position: refs/branch-heads/2924@{#128}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[M56] Consolidate how ImageDocument sets image styling
* Consolidate how the image sets the cursor styling inside of
updateImageStyle(), which now checks for whether the cursor
or checkerboard size has changed during styling updates.
* Fix how the magnifying glass cursor is initialized on desktop
versions of the page.
BUG=664782
[email protected]
Review URL: https://codereview.chromium.org/2535063002 .
Original-Review-Url: https://codereview.chromium.org/2523553002
Original-Cr-Commit-Position: refs/heads/master@{#434020}
Cr-Commit-Position: refs/branch-heads/2924@{#127}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix for DragEnd event being sent with the wrong coordinates.
This event was accidentally sent with (x, x) instead of (x, y). This
patch corrects this.
BUG=667963
TBR=paulmeyer, lukasza, nick
Review-Url: https://codereview.chromium.org/2530663002
Cr-Commit-Position: refs/heads/master@{#434295}
(cherry picked from commit 94c098de407049a62aebef939cb7ce93200a5139)
Review URL: https://codereview.chromium.org/2533953002 .
Cr-Commit-Position: refs/branch-heads/2924@{#126}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge M56: "Fix MediaServerCrashListener JNI registration"
Commit f524383bbd03acfba4ffe18b7e77a66c46228dcd introduced the
MediaServerCrashListener, but did not properly call the method to
register the native methods with JNI.
This change properly registers the native methods.
BUG=667149
Review-Url: https://codereview.chromium.org/2527553002
Cr-Commit-Position: refs/heads/master@{#434044}
(cherry picked from commit 89f2b9bf3f9fece35f1e8c01554db10c55374970)
Review URL: https://codereview.chromium.org/2536623004 .
Cr-Commit-Position: refs/branch-heads/2924@{#125}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Set alpha on inactive user row without using a layer.
BUG=667205
Review-Url: https://codereview.chromium.org/2519243002
Cr-Commit-Position: refs/heads/master@{#433873}
(cherry picked from commit bc96fccd56aa58d9c45772e274d8ade141e415d5)
Review URL: https://codereview.chromium.org/2538523002 .
Cr-Commit-Position: refs/branch-heads/2924@{#124}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Implemented correct layout for system menu's system info row.
The separater in the system info row is will now align with the tile
row separators.
BUG=662975
TEST=ash_unittests ---gtest_filter=SystemInfoDefaultViewTest.*
Review-Url: https://codereview.chromium.org/2514403002
Cr-Commit-Position: refs/heads/master@{#433699}
(cherry picked from commit d7ca2fd0c335223efbcf69a952f14f2a06e242dd)
Review URL: https://codereview.chromium.org/2532953003 .
Cr-Commit-Position: refs/branch-heads/2924@{#123}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix LabelButton size calculation for non-default fonts.
BUG=666479
Review-Url: https://codereview.chromium.org/2514163002
Cr-Commit-Position: refs/heads/master@{#433670}
(cherry picked from commit 27ec4f8bcae25e024776f5f97390f768b5b47f49)
Review URL: https://codereview.chromium.org/2539523002 .
Cr-Commit-Position: refs/branch-heads/2924@{#122}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix event targeting for overlay scrollbar thumbs (in native UI).
Views with layers are targeted based on their layer's transform rather
than their local coordinates. See View::GetTransform(). Hence the thumb
did not receive events until the translated area was hovered. To resolve
this, make the thumb 11 + 4 = 15 dp wide all the time, and just slide
back and forth so that 4dp is off the left or 4dp is off the right of
the 11dp track, making sure the thumb always covers the whole track
(it won't extend beyond visually or in terms of event handling because
of the track's layer clipping).
BUG=666798
Review-Url: https://codereview.chromium.org/2520433003
Cr-Commit-Position: refs/heads/master@{#433664}
(cherry picked from commit 03722d39ae28885ebd6de91429325776c77da2a7)
Review URL: https://codereview.chromium.org/2535943002 .
Cr-Commit-Position: refs/branch-heads/2924@{#121}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Some PannerOptions dictionary members should be doubles
Some of the dictionary members were incorrectly declared to be floats
when they should have been doubles. The corresponding attributes
themselves are doubles so the members should match.
See https://webaudio.github.io/web-audio-api/#panneroptions
BUG=666471
TEST=constructor/panner.html updated
Review-Url: https://codereview.chromium.org/2508733006
Cr-Commit-Position: refs/heads/master@{#433217}
(cherry picked from commit a4eae706d4f07f9d297ce0f8d8cbc2bf07618598)
Review URL: https://codereview.chromium.org/2536603003 .
Cr-Commit-Position: refs/branch-heads/2924@{#120}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[MediaRouter, Android] Check request before use
Tentative null check crasher fix.
BUG=664384
TEST=None
[email protected]
Review-Url: https://codereview.chromium.org/2526113002
Cr-Commit-Position: refs/heads/master@{#434529}
(cherry picked from commit 6e15e9d533fe44b26beca64dce6d90d8962c65db)
Review URL: https://codereview.chromium.org/2533913002 .
Cr-Commit-Position: refs/branch-heads/2924@{#119}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
tweak the focus rectangle of TrayBackgroundView objects
BUG=640678
TEST=Manually tested on lock screen and signin screen, also after signin.
Review-Url: https://codereview.chromium.org/2513823002
Cr-Commit-Position: refs/heads/master@{#433662}
(cherry picked from commit dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc)
Review URL: https://codereview.chromium.org/2533903002 .
Cr-Commit-Position: refs/branch-heads/2924@{#118}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Show "Connected" Bluetooth icon on system menu when there is at least one connected device.
In the 1st layer of MD system menu, we show a separate icon for Bluetooth menu
when Bluetooth is enabled and there is at least one connected device.
BUG=652665
TEST=manually confirmed.
Review-Url: https://codereview.chromium.org/2512923002
Cr-Commit-Position: refs/heads/master@{#433483}
(cherry picked from commit 607c0c0072fbb639b0d94fed81a7f9e28559e520)
Review URL: https://codereview.chromium.org/2535033002 .
Cr-Commit-Position: refs/branch-heads/2924@{#117}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix renderer crashes due to non-existing RenderFrameImpl or WebFrameWidget during Navigations (merge to M56)
When navigating the main frame, the RenderViewImpl lingers around with no WebFrameWidget.
This yields a WebViewImpl in a call to RenderWidget::GetWebWidget().
When user interactions leads to an IME IPC for FirstRectForCharacterRange, the IPC migth arrive during the
navigation and lead to an invalid cast in TextInputClientObserver::GetFocusedFrame().
This CL will avoid those casts by explicitly verifying that the WebWidget returned from GetWebWidget() is a WebFrameWidget.
Also, the IPC handling in TextInputClientObserver is modified such that it now considers the possibilities
of nullptr outputs from GetFocusedFrame() and GetWebFrameWidget().
BUG=664890
Review-Url: https://codereview.chromium.org/2526563004
Cr-Commit-Position: refs/heads/master@{#434302}
(cherry picked from commit 95df18c257f410cff287f0b402dd50b3014c7784)
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2533003002
Cr-Commit-Position: refs/branch-heads/2924@{#116}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Ensure NetworkHandler is initialized in WifiDataProviderChromeOs
BUG=661304
Review-Url: https://codereview.chromium.org/2515363003
Cr-Commit-Position: refs/heads/master@{#433943}
(cherry picked from commit 9ae7d75c5f2a4239364e79c0fcbbd64c5795a72f)
Review URL: https://codereview.chromium.org/2531403002 .
Cr-Commit-Position: refs/branch-heads/2924@{#115}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge M-56] Mark PaymentDetails.error as experimental
There has not been a request to implement and ship this feature, so it
should be marked as experimental until such request has been sent out
and consequently approved.
BUG=648240
Review-Url: https://codereview.chromium.org/2530713002
Cr-Commit-Position: refs/heads/master@{#434664}
(cherry picked from commit 1f7a87077603d65b6ac7d2cbf6dca8a3bff8ec87)
Review URL: https://codereview.chromium.org/2534993002 .
Cr-Commit-Position: refs/branch-heads/2924@{#114}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Notifications] Make image background white like notification background
Suggested by UI reviewers, and looks a little cleaner.
BUG=668087
Review-Url: https://codereview.chromium.org/2522083003
Cr-Commit-Position: refs/heads/master@{#434225}
(cherry picked from commit 1da7201bea9f6d2cd10619638fca3f0526778d73)
Review URL: https://codereview.chromium.org/2535873002 .
Cr-Commit-Position: refs/branch-heads/2924@{#113}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge M-56] Mark IFrame support in PaymentRequest experimental
IFrame support in PaymentRequest may be better served through
FeaturePolicy. This patch marks the current IFrame support
experimental, so it's disabled by default, but developers still can
experiment with it. Once the FeaturePolicy question is resolved, the
current implementation of the IFrame support will be either shipped or
replaced by FeaturePolicy.
BUG=652148
Review-Url: https://codereview.chromium.org/2525813003
Cr-Commit-Position: refs/heads/master@{#434257}
(cherry picked from commit d2c4379ec3783f7f70b14f6fda92f13cd496bf66)
Review URL: https://codereview.chromium.org/2529423002 .
Cr-Commit-Position: refs/branch-heads/2924@{#112}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Do not crash in SpdyHttpStream::GetTokenBindingSignature() if SpdySession is already destroyed.
BUG=667683
Review-Url: https://codereview.chromium.org/2525723003
Cr-Commit-Position: refs/heads/master@{#434213}
(cherry picked from commit 037eff137c8bc5e6685992f93b0f6721e8bbed7a)
Review URL: https://codereview.chromium.org/2534923002 .
Cr-Commit-Position: refs/branch-heads/2924@{#111}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix build on 2924 branch
3 Merges for crbug.com/633007 on M56 branch (2924) had a glich
that caused compile error.
This fixes the compilation error.
[email protected]
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=633007, 668933
Review-Url: https://codereview.chromium.org/2533743002
Cr-Commit-Position: refs/branch-heads/2924@{#110}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully
GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
strings for particular IDs contain placeholders, and attempts to access the
vector of offsets corresponding to such placeholders. However, in some
situations (http://crbug.com/658902#c18) the localised string may be empty.
This led to an out-of-bounds access and crash on Android.
This CL is the smallest change to handle such situation gracefully -- it checks
the length of the vector with offsets and gives up accessing it if it is empty.
This avoids the crash but results in displaying a UI with empty strings.
Ideally, the UI would also be supressed on these occasions, but that is left
for follow-up CLs. The current situation is already an improvement (password
manager is still not very useful, but at least the browser has a chance to
continue).
The CL also removes the temporary logging put in for the crash investigation.
BUG=658902
Review-Url: https://codereview.chromium.org/2526283002
Cr-Commit-Position: refs/heads/master@{#434482}
(cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)
Review URL: https://codereview.chromium.org/2534793003 .
Cr-Commit-Position: refs/branch-heads/2924@{#109}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add a UseCounter for '>>>' combinator.
BUG=633007
[email protected] for histograms.xml
Review-Url: https://codereview.chromium.org/2517043002
Cr-Commit-Position: refs/heads/master@{#433484}
(cherry picked from commit ea3f73b7066df2f90e2ea56d280f6646760d4f35)
Review URL: https://codereview.chromium.org/2528313002 .
Cr-Commit-Position: refs/branch-heads/2924@{#108}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Matching part for >>> (shadow-piercing descendant combinator).
Parsing part is done in the previous dependent CL.
https://codereview.chromium.org/2500813003/
This CL implements matching '>>>' shadow-piercing descendant
combinator in static profile.
Note that the combinator only pierces through open shadow roots
and not V0 or closed shadow roots.
BUG=633007
Review-Url: https://codereview.chromium.org/2496123002
Cr-Commit-Position: refs/heads/master@{#433457}
(cherry picked from commit 04a4852c265670de8100ceee3e20215f4a56091f)
Review URL: https://codereview.chromium.org/2532813002 .
Cr-Commit-Position: refs/branch-heads/2924@{#107}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Parser support for >>> (shadow-piercing descendant) combinator.
'>>>' (shadow-piercing descendant) can only be parsed in
static profile. The parsing is guarded by a runtime enabled flag.
Matching part is done in the next CL:
https://codereview.chromium.org/2496123002/
BUG=633007
Review-Url: https://codereview.chromium.org/2500813003
Cr-Commit-Position: refs/heads/master@{#433133}
(cherry picked from commit 69635dc029d7ce77e7db12669a994295d5f93952)
Review URL: https://codereview.chromium.org/2528303002 .
Cr-Commit-Position: refs/branch-heads/2924@{#106}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.9
Cr-Commit-Position: refs/branch-heads/2924@{#105}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Makes delay commitText/setComposition can deal with empty text/composition.
BUG=668036
Review-Url: https://codereview.chromium.org/2525723005
Cr-Commit-Position: refs/heads/master@{#434426}
(cherry picked from commit 89a156914461e445488deeca97a453997540e010)
Review URL: https://codereview.chromium.org/2532803002 .
Cr-Commit-Position: refs/branch-heads/2924@{#104}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.8
Cr-Commit-Position: refs/branch-heads/2924@{#103}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.7
Cr-Commit-Position: refs/branch-heads/2924@{#102}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Reland "Only promote opaque scrollers which are stacking contexts."
Relanding https://codereview.chromium.org/2509203002/. Originally failed the
svg/as-background-image/svg-width-100p-as-background.html test on android, this time removing the custom expectation for android.
TBR=schenney, pdr
BUG=666147
TEST=PaintLayerScrollableAreaTest.NonContainedLayersNotPromoted
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2522043002
Cr-Commit-Position: refs/heads/master@{#434201}
(cherry picked from commit 79b54819da38f8047e234a647e21998e09b75e5f)
Review URL: https://codereview.chromium.org/2536443002 .
Cr-Commit-Position: refs/branch-heads/2924@{#101}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Round the scroll offset synced back to main instead of flooring.
When scrolling up, flooring the scroll delta sent back to main can result
in main thinking that we have scrolled up by a pixel while cc still positions
layers as if we are at the old scroll position. To be technically correct
according to the frame that will be produced, we would need to round according
to the current scroll snap size but this isn ot easily known at the time of
rounding so we use the nearest integer since this is the common case.
BUG=663291
TEST=LayerTreeHostImplTest.SyncSubpixelScrollDelta
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2511473003
Cr-Commit-Position: refs/heads/master@{#434022}
(cherry picked from commit 75a7e4cb1ec29ded2e52539259233356caa883c8)
Review URL: https://codereview.chromium.org/2529013003 .
Cr-Commit-Position: refs/branch-heads/2924@{#100}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
LayoutView's paint layer should clip to the full viewport size.
This patch makes it so that the LayoutView's painting size is always at least
the size of the layout viewport. Today (without root-layer-scrolls), the
LayoutView's PaintLayer (and its parent root content layer) is sized to contain
all the document's content and is clipped and scrolled by the PaintLayers
belonging to the Frame's PaintLayerCompositor (the Frame Scroll and Clipping
layers). This is problematic if the content is smaller than the viewport since
position: fixed elements are attached to the viewport but are not counted as
part of the LayoutView's "layout overflow".
This occurs in two situations (both occur only on Android):
1. Bug 666806 - With inert top controls on and the top controls hidden, a page
whose document is empty (for e.g.) will produce a LayoutView layer whose height
is the height of the viewport minus the height of the top controls. This means
bottom position: fixed elements will get clipped.
2. Bug 436871 - If the content on a page is wider than the ICB, Chrome will
grow the layout viewport until its width covers all the content (or the minimum
scale is reached), keeping the aspect-ratio fixed. When this happens, the
layout viewport can become taller than the content resulting in clipping of
bottom position: fixed elements. (This is related to crbug.com/492871).
This patch fixes both issues.
BUG=666806,436871
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2519163003
Cr-Commit-Position: refs/heads/master@{#434303}
(cherry picked from commit a226f0e367ee7e064cc398d0b76d347d53103295)
Review URL: https://codereview.chromium.org/2531913002 .
Cr-Commit-Position: refs/branch-heads/2924@{#99}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.6
Cr-Commit-Position: refs/branch-heads/2924@{#98}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Offline pages] Add UMA to duplicate request when saving a download
Adds a histogram for tracking a time distance between 2 requests that
are made for the same URL.
BUG=655506
Review-Url: https://codereview.chromium.org/2523853003
Cr-Commit-Position: refs/heads/master@{#434338}
(cherry picked from commit 30f852cc7cefe9d82c32563e1c5dbb5976cb5c58)
Review URL: https://codereview.chromium.org/2527283002 .
Cr-Commit-Position: refs/branch-heads/2924@{#97}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Offline pages] Adding UMA for time between saved page and time of duplicate request
Updates the signature of OfflinePageUtil::CheckExistenceOfPagesWithURL
to include the latest_saved_time of the duplicate pages.
Uses the time in ModelDuplicateCheckDone (in OfflinePageDownloadBridge)
to report the newly added UMA to track request time since last
page with the same URL was saved:
OfflinePages.DownloadRequestTimeSinceDuplicateSaved
BUG=655506
Review-Url: https://codereview.chromium.org/2518143002
Cr-Commit-Position: refs/heads/master@{#434281}
(cherry picked from commit e8aae2cd4f0852bd9ba0d3774d00dd6d5bf35846)
Review URL: https://codereview.chromium.org/2530953002 .
Cr-Commit-Position: refs/branch-heads/2924@{#96}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Clicking "SIGN IN" should bring up the 'update GMS' dialog if GMS is out-of-date
Note that the user might dismiss the dialog and click the button again.
BUG=666850
Review-Url: https://codereview.chromium.org/2519173002
Cr-Commit-Position: refs/heads/master@{#433891}
(cherry picked from commit b541524b58c305ebfa0f1537ffef3abb6450cfe5)
Review URL: https://codereview.chromium.org/2530033002 .
Cr-Commit-Position: refs/branch-heads/2924@{#95}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
PS - Adjusting Public Session login pod for expanded whitelisting
Approximate mocks of the new design https://folio.googleplex.com/cros-public-session-ui
BUG=667051
Review-Url: https://codereview.chromium.org/2516903002
Cr-Commit-Position: refs/heads/master@{#434153}
(cherry picked from commit 12f48eb6682abca50f059b65beebc31d49fad3f4)
Review URL: https://codereview.chromium.org/2532503002 .
Cr-Commit-Position: refs/branch-heads/2924@{#94}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Repaint SVG subtree on viewport changes (resize)
When the (outermost) <svg> is sized using percentages, and an ancestor
changes size, the LayoutSVGRoot will be marked for layout (even though
the dimension/initial viewport changes.)
Since changed dimensions can imply a new scale factor (for instance from
interactions with a viewBox) or previously clipped content being
exposed, we need to issue paint invalidations for the entire SVG.
BUG=665912
Review-Url: https://codereview.chromium.org/2511353002
Cr-Commit-Position: refs/heads/master@{#433622}
(cherry picked from commit 69d94df4b088b45440f335e6be53399b80e7292f)
Review URL: https://codereview.chromium.org/2525333002 .
Cr-Commit-Position: refs/branch-heads/2924@{#93}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Make the search geolocation disclosure infobar always show on top.
This makes this infobar always show on the top of the infobar stack, so
it will be visible even if other infobars are already on screen.
This is done by adding a virtual showInFront method to the abstract
infobar Item base class.
BUG=661011
Review-Url: https://codereview.chromium.org/2510013002
Cr-Commit-Position: refs/heads/master@{#433128}
(cherry picked from commit 4fd0154a4938f485dd975ede049c13fe47522902)
Review URL: https://codereview.chromium.org/2527063002 .
Cr-Commit-Position: refs/branch-heads/2924@{#92}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Update string for geolocation omnibox disclosure.
BUG=661011
Review-Url: https://codereview.chromium.org/2517453002
Cr-Commit-Position: refs/heads/master@{#433104}
(cherry picked from commit 5bdfaca9d17a6db278e5dcabe689e39802755f5d)
Review URL: https://codereview.chromium.org/2526203002 .
Cr-Commit-Position: refs/branch-heads/2924@{#91}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Changed the audio row mute button ink drop to a circle.
BUG=667934
Review-Url: https://codereview.chromium.org/2525763002
Cr-Commit-Position: refs/heads/master@{#434065}
(cherry picked from commit 303f5f7eb72d8dd96bb54e11c5e8ab4bb2048c39)
Review URL: https://codereview.chromium.org/2527783006 .
Cr-Commit-Position: refs/branch-heads/2924@{#90}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Changed system menu default-detailed transtiion animation duration to 100ms from 80ms.
BUG=667935
Review-Url: https://codereview.chromium.org/2525553004
Cr-Commit-Position: refs/heads/master@{#434059}
(cherry picked from commit bd397d9f3ccd6bc066738edf8200cc49f7b900f6)
Review URL: https://codereview.chromium.org/2527013002 .
Cr-Commit-Position: refs/branch-heads/2924@{#89}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.5
Cr-Commit-Position: refs/branch-heads/2924@{#88}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Allow to create ARC++ windows minimized on startup.
TEST=Tested with OneNote badge.
BUG=667608
Review-Url: https://codereview.chromium.org/2517833003
Cr-Commit-Position: refs/heads/master@{#433824}
(cherry picked from commit 43961ed73ccb8a76e6621fcdbe0a930aa88a42b3)
Review URL: https://codereview.chromium.org/2525183002 .
Cr-Commit-Position: refs/branch-heads/2924@{#87}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
M56: Printing: Fix more RenderView vs RenderFrame ID confusion.
BUG=667208
Review-Url: https://codereview.chromium.org/2517253004
Cr-Commit-Position: refs/heads/master@{#433857}
(cherry picked from commit 5793507cab680a222694a80f78ff97d3d03302a2)
Review URL: https://codereview.chromium.org/2523333002 .
Cr-Commit-Position: refs/branch-heads/2924@{#86}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[merge-m56] [mac] Disable usage of full size content view.
Usually AppKit gives the contentView of a framed NSWindow an
NSThemeFrame as its superview. For a long time, Chrome has hacked around
this requirement, so we have more control over the frame layout. We
would instead add our contentView as a sibling of NSThemeFrame. But
AppKit warns, "NSWindow warning: adding an unknown subview" when we do
this.
In r424609 we started using NSFullSizeContentViewWindowMask to avoid the
warning. However, NSThemeFrame uses autolayout for the "traffic
light" buttons.
The prevailing theory is that adding the browser view hierarchy as a
subview of NSThemeFrame (rather than a sibling) we are unexpectedly
increasing the exposure that the browser view layout has to autolayout;
layout constraints and the constraint resolution alogithm. This resulted
in some known performance and layout regressions (fixed in r427290 and
r432024).
There's concern of additional, yet unknown regressions. So we want to
revert to the old ways for m56 so there is time for additional analysis.
BUG=666415
Review-Url: https://codereview.chromium.org/2521453002
Cr-Commit-Position: refs/heads/master@{#433658}
(cherry picked from commit fd7cfb578fb058ee68c19051fb1ecd564b563f73)
Review URL: https://codereview.chromium.org/2523323002 .
Cr-Commit-Position: refs/branch-heads/2924@{#85}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Change the Data Saver infobar promo icon to blue
All of Data Saver's UI should use the blue icon. The infobar promo needs
to use the existing blue icon rather than the app_icon.
BUG=660356
Review-Url: https://codereview.chromium.org/2525843002
Cr-Commit-Position: refs/heads/master@{#434104}
(cherry picked from commit cbd68308efc017962dc15fa9fa6dc8a30bd885f6)
Review URL: https://codereview.chromium.org/2530673002 .
Cr-Commit-Position: refs/branch-heads/2924@{#84}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
M56: Make printing work for PDF and Flash.
BUG=666432
Review-Url: https://codereview.chromium.org/2518993002
Cr-Commit-Position: refs/heads/master@{#433657}
(cherry picked from commit 4665756d5cdece234b38a2c722f2489a5c53a647)
Review URL: https://codereview.chromium.org/2523283002 .
Cr-Commit-Position: refs/branch-heads/2924@{#83}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Don't show the remaining time for offline page downloads
For offline page downloads, we don't know the remaining time.
Just show the downloading string should be fine.
BUG=665553
[email protected]
Review-Url: https://codereview.chromium.org/2514603002
Cr-Commit-Position: refs/heads/master@{#433238}
(cherry picked from commit ba84a485f4f812beb9631d22320a68939aaac15f)
Review URL: https://codereview.chromium.org/2523603005 .
Cr-Commit-Position: refs/branch-heads/2924@{#82}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Reland: [IndexedDB] Delete callbacks state on worker thread exit.
During refactoring of r430110 the logic to actually delete the internal
state of IndexedDBCallbacksImpl and IndexedDBDatabaseCallbacksImpl
objects that lives on worker threads was accidentally removed.
This reland will fix the DCHECK encountered when actually exercising
this deletion path.
BUG=667465
Review-Url: https://codereview.chromium.org/2524823002
Cr-Commit-Position: refs/heads/master@{#434030}
(cherry picked from commit 6d1044b605d7dfa073437e09fd966f306137a0c9)
Review URL: https://codereview.chromium.org/2526913002 .
Cr-Commit-Position: refs/branch-heads/2924@{#81}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Avoid shoing progress bar on "pending" download notifications. They still should remain "ongoing".
BUG=667011
Review-Url: https://codereview.chromium.org/2514783003
Cr-Commit-Position: refs/heads/master@{#433957}
(cherry picked from commit 10ed1daf560c4d99c6f5235878680d88d48c1307)
Review URL: https://codereview.chromium.org/2523243003 .
Cr-Commit-Position: refs/branch-heads/2924@{#80}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[BlobStorage] Fix UMA reporting.
[email protected]
BUG=666862
Review-Url: https://codereview.chromium.org/2514513004
Cr-Commit-Position: refs/heads/master@{#433760}
(cherry picked from commit 1e85b53656cc7053706890de27b3061a1390a153)
Review URL: https://codereview.chromium.org/2521723008 .
Cr-Commit-Position: refs/branch-heads/2924@{#79}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Properly handle errors on server queries in Autofill.
PersonalDataManager::OnWebDataServiceRequestDone originally only had pending_creditcards_query_ and pending_profiles_query_. r81595 added support for zero-ing out those query variables in case there was an error.
r309140 added support for server queries with pending_server_creditcards_query_ and pending_server_profiles_query_, and extended OnWebDataServiceRequestDone to handle their results, but never extended it to handle their errors.
BUG=659023
Review-Url: https://codereview.chromium.org/2517103003
Cr-Commit-Position: refs/heads/master@{#433645}
(cherry picked from commit 988a599c9d4426210a6c5a8164fef3dd6391dbdd)
Review URL: https://codereview.chromium.org/2530593002 .
Cr-Commit-Position: refs/branch-heads/2924@{#78}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Android: Turn off acceleration for samsung device
Certain devices on android jellybean stop crashing when hardware
acceleration is turned off. Adding one such check to fix a large portion
of crashes on stable channel.
BUG=651918
Review-Url: https://codereview.chromium.org/2521913003
Cr-Commit-Position: refs/heads/master@{#433950}
(cherry picked from commit 0857dc75f827cb7db86b062a31f656cb35c07e4a)
Review URL: https://codereview.chromium.org/2523083003 .
Cr-Commit-Position: refs/branch-heads/2924@{#77}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Reland of [NTP] Refresh download list when NTP is open. (patchset #1 id:1 of https://codereview.chromium.org/2511973005/ )
Reason for revert:
I am going to solve the initial issue.
Original issue's description:
> Revert of [NTP] Refresh download list when NTP is open. (patchset #2 id:20001 of https://codereview.chromium.org/2508133004/ )
>
> Reason for revert:
> Broke tests.
> See crbug.com/666744
>
> Original issue's description:
> > [NTP] Refresh download list when NTP is open.
> >
> > So that we do not show on new NTPs items which were removed bypassing Chrome.
> >
> > BUG=666262
> >
> > Committed: https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d
> > Cr-Commit-Position: refs/heads/master@{#433174}
>
> [email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=666262
>
> Committed: https://crrev.com/e259c656eefd44425e3075ccec88853b7ec5fef8
> Cr-Commit-Position: refs/heads/master@{#433195}
BUG=666262
Review-Url: https://codereview.chromium.org/2510423002
Cr-Commit-Position: refs/heads/master@{#433210}
(cherry picked from commit 8db51905a4c2cb2f154cab9bc184691091996cfe)
Review URL: https://codereview.chromium.org/2523243002 .
Cr-Commit-Position: refs/branch-heads/2924@{#76}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add a count for Suggested Articles usage.
BUG=665873
Review-Url: https://codereview.chromium.org/2510053002
Cr-Commit-Position: refs/heads/master@{#433182}
(cherry picked from commit b0ed4eb7afa96fadc7404597c9b5d3b01db1e547)
Review URL: https://codereview.chromium.org/2528683003 .
Cr-Commit-Position: refs/branch-heads/2924@{#75}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Incrementing VERSION to 56.0.2924.4
Cr-Commit-Position: refs/branch-heads/2924@{#74}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
ChromeOS: disable MD OOBE by default.
BUG=667010
TEST=none
Review-Url: https://codereview.chromium.org/2519633002
Cr-Commit-Position: refs/heads/master@{#433749}
(cherry picked from commit b838d7ccd4a8a9c308aea5ebc6ac8a1fc84f731f)
Review URL: https://codereview.chromium.org/2515313006 .
Cr-Commit-Position: refs/branch-heads/2924@{#73}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Removed leftover enums from WebGL 2.0 rendering context.
(Removes WebGL conformance roll that was included on master branch)
BUG=666927
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2518623004
Cr-Commit-Position: refs/heads/master@{#433573}
(cherry picked from commit b368c8ec4a79496fb2816aa79d3e5c235a4843c4)
Review URL: https://codereview.chromium.org/2521323004 .
Cr-Commit-Position: refs/branch-heads/2924@{#72}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix semantics of uploading HTML sources to 3D textures.
The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.
The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.
Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .
(Removes WebGL conformance roll that was included on master branch)
BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2511153002
Cr-Commit-Position: refs/heads/master@{#433079}
(cherry picked from commit d481a01bc050798a91512bdad6a70fccf0cb27a3)
Review URL: https://codereview.chromium.org/2520043004 .
Cr-Commit-Position: refs/branch-heads/2924@{#71}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[OfflinePages] Notification updates for foreground SavePageLater request
Now perform MarkAttemptStarted and MarkAttemptAborted for disabled
requests that get EnableForOffliner().
Also:
- Fixes bug where request could be left in OFFINER state if it
wasn't accepted by Offliner.
- Fixes a bug where completing a disabled request was calling
TryNextRequest even though it could not have been running in
the background nor is it part of the background processing state
machine.
- Adds a unittest for EnableForOffliner
BUG=667085
Review-Url: https://codereview.chromium.org/2502363007
Cr-Commit-Position: refs/heads/master@{#433908}
(cherry picked from commit 23264bd497e26f06d4509f3a1560a948333f49c9)
Review URL: https://codereview.chromium.org/2521853004 .
Cr-Commit-Position: refs/branch-heads/2924@{#70}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[OfflinePages] Adds queue depth uma when processing begins.
Differentiates between type of processing (immediate vs. scheduled) and
svelte vs. non-svelte.
BUG=656100
Review-Url: https://codereview.chromium.org/2496383003
Cr-Commit-Position: refs/heads/master@{#433097}
(cherry picked from commit f3e48720f5e19a32d265fd5afa9ad19bbd415367)
Review URL: https://codereview.chromium.org/2525853002 .
Cr-Commit-Position: refs/branch-heads/2924@{#69}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[ash-md] Added a delay between system menu default/detailed view transitions.
This change adds a delay before initiating the transtions to/from
the default/detailed views in the system menu in an effort to make the
ink drop animation on the clicked target more noticable.
BUG=664823
TEST=ash_unittests
Review-Url: https://codereview.chromium.org/2494943005
Cr-Commit-Position: refs/heads/master@{#433366}
(cherry picked from commit eb01167a5b2d97d18446ca7b502761d658a7a995)
Review URL: https://codereview.chromium.org/2523043003 .
Cr-Commit-Position: refs/branch-heads/2924@{#68}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge to 2924] Fix unable to delete extensions continuously through keyboard
Changes:
(1) revert the cl in Issue 2451323002.
(2) using a different approach, which is to avoid restorefocusedview call if desktopnativewidget is not active (since that should be handled in HandleActivationChanged call).
BUG=665380
[email protected]
TEST=manual test see bug fixed.
Also, this reverts the cl in Issue 2451323002, checked that the bug in that issue is not regressed.
Review-Url: https://codereview.chromium.org/2517663002
Cr-Commit-Position: refs/heads/master@{#433706}
(cherry picked from commit 34ce9a4718f571b8f8ee0f95b6d153aff38223db)
Review URL: https://codereview.chromium.org/2525823002 .
Cr-Commit-Position: refs/branch-heads/2924@{#67}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge to M56: Do not show "DOWNLOAD PAGE LATER" button under incognito mode
BUG=667150
Review-Url: https://codereview.chromium.org/2520163002
Cr-Commit-Position: refs/heads/master@{#433976}
(cherry picked from commit 60c5bb10b3d021f9f4a84c795ae8ddeb49a02b71)
Review URL: https://codereview.chromium.org/2523043002 .
Cr-Commit-Position: refs/branch-heads/2924@{#66}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Use /DialogWhenLarge theme for AccountSigninActivity same as FirstRunActivity
BUG=666068
Review-Url: https://codereview.chromium.org/2511833002
Cr-Commit-Position: refs/heads/master@{#433197}
(cherry picked from commit f8729e0ee407e5a2f14c0dee2e0d94d06d27f15c)
Review URL: https://codereview.chromium.org/2522063002 .
Cr-Commit-Position: refs/branch-heads/2924@{#65}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Revert of Plumbing for login apps device policy to extensions. (patchset #6 id:100001 of https://codereview.chromium.org/2306143002/ )
Reason for revert:
After this change, Chrome keeps crashing on the login screen (reproduced on a minnie device).
Original issue's description:
> Plumbing for login apps device policy to extensions.
>
> This CL succeeeds the CL #2150483004
>
> ChromeProcessManagerDelegate:
> * Enable background pages for apps in the login profile when
> command-line switch --enable-login-apps is set.
>
> ExtensionManagement:
> * Factor out common code into GetInstallListByMode from
> GetForceInstallList and GetRecommendedInstallList.
> * Common function UpdateForcedExtensions.
>
> ExtensionSystemImpl:
> * Enable extensions in login profile when command-line switch
> --enable-login-apps is set.
>
> ExternalProviderImpl:
> * In CreateExternalProviders, create an ExternalPolicyLoader for login
> apps in the login profile.
>
> ExtensionInstallListPolicyHandler:
> * Common base class to parse login and force extension install lists.
>
> * Switch --enable-login-apps to enable login apps.
> * Extension pref extensions.install.loginlist.
>
> BUG=576464
>
> Committed: https://crrev.com/3bbfabe266cd5138393d3e87229de567d19da005
> Cr-Commit-Position: refs/heads/master@{#432917}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=576464
Review URL: https://codereview.chromium.org/2525483004 .
Cr-Commit-Position: refs/branch-heads/2924@{#64}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Limit Link header based SW installations for fetches made by SW.
To prevent a service worker from spawning new service workers in the
background, only process link headers on requests made by service
workers if the service worker is controlling at least one client.
BUG=662443
Review-Url: https://codereview.chromium.org/2512103003
Cr-Commit-Position: refs/heads/master@{#433489}
(cherry picked from commit e8313bb499c439b0a5091225faf97b06f4cf1182)
Review URL: https://codereview.chromium.org/2525723002 .
Cr-Commit-Position: refs/branch-heads/2924@{#63}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add a use counter for Link rel=serviceworker headers.
Even though these link headers aren't processed in blink, this is still
the most sensible place for a use counter for these.
BUG=582310,667086
Review-Url: https://codereview.chromium.org/2513183002
Cr-Commit-Position: refs/heads/master@{#433444}
(cherry picked from commit 9c76cfaf64b27534abe2663b2a1768737d64d4f9)
Review URL: https://codereview.chromium.org/2521153004 .
Cr-Commit-Position: refs/branch-heads/2924@{#62}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Fix crash when clicking network row on Chrome OS OOBE
Fixes a crash when clicking on the network row of
the material design system menu while in the
OOBE user flow. The crash resulted in mistakenly
calling up to a SpecialPopupRow member in the
network UI code, but SpecialPopupRow is not used
in Ash MD.
BUG=666635
TEST=Click network row in system menu when on OOBE screen
Review-Url: https://codereview.chromium.org/2516303005
Cr-Commit-Position: refs/heads/master@{#433718}
(cherry picked from commit 3aacb0721c8afabf5cc1c9d7faf34b1b1422db8b)
Review URL: https://codereview.chromium.org/2521903003 .
Cr-Commit-Position: refs/branch-heads/2924@{#61}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Merge "Don't call dispose() if the WebPluginContainer wasn't created"
If the plugin fails to load, then there is nothing to dispose.
BUG=654556
Review-Url: https://codereview.chromium.org/2512023003
Cr-Commit-Position: refs/heads/master@{#433096}
(cherry picked from commit a14a834fbf75248948031bb240c10c5494972432)
Review URL: https://codereview.chromium.org/2520413003 .
Cr-Commit-Position: refs/branch-heads/2924@{#60}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Offline pages] Addressing several reload snackbar issues
* Solves the problem of snackbar not working after incognito tabs being
dismissed
* solves the problem of snackbar not working when there is a download
happening in between.
BUG=663263,662353,660577
Review-Url: https://codereview.chromium.org/2520583002
Cr-Commit-Position: refs/heads/master@{#433700}
(cherry picked from commit b7c13b94eafad8d7458bde05ca6733eb11d731be)
Review URL: https://codereview.chromium.org/2529433002 .
Cr-Commit-Position: refs/branch-heads/2924@{#59}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[M-56] Define helper constant in payment tests.
This patch fixes compile of Android integration tests. A merge into M-56
of a bug fix with tests was relying on DECEMBER, NEXT_YEAR, and
FIRST_BILLING_ADDRESS to be defined elsewhere, but that definition was
in a patch that does not need to be merged into M-56.
BUG=667353
[email protected]
Review URL: https://codereview.chromium.org/2518403002 .
Cr-Commit-Position: refs/branch-heads/2924@{#58}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge M-56] Return cached query result for canMakeActivePayment.
The PaymentRequest.canMakeActivePayment() feature, which is currently
hidden behind a flag, throttles queries of supported methods to reduce
the risk of user fingerprinting. Since the upcoming (not yet
implemented) 'basic-card' method can be used with different subsets of
card networks ('visa', 'mastercard', etc.) and types ('credit', 'debit',
'prepaid'), this patch changes canMakeActivePayment() to return last
cached result instead of re-querying every time. This also happens to be
more inline with the proposed specification language:
"Multiple calls to canMakeActivePayment will result in cached response
from previous call."
Proposed PaymentRequest.canMakeActivePayment() specification:
https://github.com/w3c/browser-payment-api/pull/316/files
BUG=662931
Review-Url: https://codereview.chromium.org/2507063009
Cr-Commit-Position: refs/heads/master@{#433689}
(cherry picked from commit 639ffbbca80f848266bb78f5ce28f0eddc7649fd)
Review URL: https://codereview.chromium.org/2524613004 .
Cr-Commit-Position: refs/branch-heads/2924@{#57}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
[Merge M-56] [Payments] New shipping address should appear in billing address suggest
BUG=667353
Review-Url: https://codereview.chromium.org/2514353003
Cr-Commit-Position: refs/heads/master@{#433595}
(cherry picked from commit 4b961830b5d2d1837fb2353374c41d28f02c2086)
Review URL: https://codereview.chromium.org/2518373002 .
Cr-Commit-Position: refs/branch-heads/2924@{#56}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Add CHECK to EnumerateDevices call in PepperDeviceManager
BUG=666715
Review-Url: https://codereview.chromium.org/2516603003
Cr-Commit-Position: refs/heads/master@{#433417}
(cherry picked from commit 48c91fbefe2cbe48472d91c265da3283bd3870b8)
Review URL: https://codereview.chromium.org/2519273003 .
Cr-Commit-Position: refs/branch-heads/2924@{#55}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
