Publish DEPS for Chromium 54.0.2840.85
Incrementing VERSION to 54.0.2840.85
Cr-Commit-Position: refs/branch-heads/2840@{#803}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Revert "Allow selection change update before beginBatchEdit" on M54
This reverts commit 4662007a92a92b016ef3f05fb4cbbd6904825cc0.
BUG=659934
Review URL: https://codereview.chromium.org/2460173003 .
Cr-Commit-Position: refs/branch-heads/2840@{#802}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Wait a few seconds for simulators to be killed, and flush each line of output written
BUG=660527
TBR=rohitrao
(cherry picked from commit 0f503047288d543f8847bbd5d49b16af02277f16)
Review-Url: https://codereview.chromium.org/2461163002
Cr-Original-Commit-Position: refs/heads/master@{#428601}
Cr-Commit-Position: refs/branch-heads/2840@{#801}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.84
Cr-Commit-Position: refs/branch-heads/2840@{#800}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Disable zero-copy DXGI video on NVIDIA GPUs
This seems to sometimes be causing videos to initially display black.
[email protected]
BUG=635319
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2314773003
Cr-Commit-Position: refs/heads/master@{#417148}
(cherry picked from commit d47c4314fc4eb97082790714281b9e3cc5b45c9c)
Review URL: https://codereview.chromium.org/2457243002 .
Cr-Commit-Position: refs/branch-heads/2840@{#799}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Kill simctl before starting iOS simulator tests
BUG=660527
(cherry picked from commit b2078ae095d322b807bd39b17f5fee29b1fa2feb)
Review-Url: https://codereview.chromium.org/2459933003
Cr-Original-Commit-Position: refs/heads/master@{#428547}
Cr-Commit-Position: refs/branch-heads/2840@{#798}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
"Fix" remaining connection error handlers in Blink
This changes all remaining Mojo connection error handlers in Blink
to no-op if invoked after Blink shutdown.
TBRing haraken@ since this solution has already been discussed and
landed in several other cases, and it's a P0.
BUG=658907
[email protected]
Review-Url: https://codereview.chromium.org/2463453002
Cr-Commit-Position: refs/heads/master@{#428468}
(cherry picked from commit d84779e26d4783df207dd66e9b7f6f5f3878c026)
Review URL: https://codereview.chromium.org/2461103002 .
Cr-Commit-Position: refs/branch-heads/2840@{#797}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.83
Cr-Commit-Position: refs/branch-heads/2840@{#796}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
[m54 merge] bugfix for ResetPromised(). Guarded by ENABLED --FLAGS_quic_bugfix_reset_promised.
Remove superfluous call to InsertLocallyClosedStreamHighestOffset() in ResetPromised().
ResetPromised() was triggering an integer overflow in GetNumLocallyClosedOutgoingStreamsHighestOffset(), because InsertLocallyClosedStreamHighestOffset() was called twice for the same stream,
The first call was from the chain ResetPromised() -> SendRstStream() -> CloseStreamInner() -> InsertLocallyClosedStreamHighestOffset(), the second was
ResetPromised() -> InsertLocallyClosedStreamHighestOffset().
The integer overflow in turn caused QuicChromiumClientSession::TryCreateStream() to queue up streams indefinitely, effectively wedging the session.
This change adds DCHECK's to detect such overflows (test-only) to
protect against such regressions in the future.
Merge internal change: 137406068
[email protected]
BUG=660076
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2453323003
Cr-Commit-Position: refs/heads/master@{#428092}
(cherry picked from commit 2f1f74cc11d45d84516ca7e32d37cb41a5ca66e6)
Review-Url: https://codereview.chromium.org/2458173002
Cr-Commit-Position: refs/branch-heads/2840@{#795}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Make the content scheme local
WebContent should not be able to embed or redirect to content scheme.
BUG=659492
Review-Url: https://codereview.chromium.org/2456883002
Cr-Commit-Position: refs/heads/master@{#428222}
(cherry picked from commit c7c7daa089804c779c4ebfb2a2b5793be6b47090)
Review URL: https://codereview.chromium.org/2455133004 .
Cr-Commit-Position: refs/branch-heads/2840@{#794}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Fix crash in DocumentOnLoadCompletedInMainFrame()
To be honest I don't totally understand how this can happen, as I would
think that when a document load completes, it would correspond to a
navigation entry that has already been committed. But this should fix
the crash in the bug.
BUG=635833
Review-Url: https://codereview.chromium.org/2363613003
Cr-Commit-Position: refs/heads/master@{#420367}
(cherry picked from commit 12334578db1688798cda0dad16e97e84faf13d90)
Review URL: https://codereview.chromium.org/2459023003 .
Cr-Commit-Position: refs/branch-heads/2840@{#793}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Stop calling Persistent::uninitialize after blink::shutdown is called.
This CL adds a short-term hack to prevent use-after-frees during a shutdown sequence.
Currently the following scenario can happen:
1) blink::shutdown() frees the underlying storage for persistent nodes.
2) ~MessageLoop() destructs some Chromium-side objects that hold Persistent.
It touches the underlying storage and crashes.
In middle term, we should entirely remove the shutdown sequence and get rid of the hack.
BUG=653688
Review-Url: https://codereview.chromium.org/2423743003
Cr-Commit-Position: refs/heads/master@{#425620}
(cherry picked from commit 10d68110da927986332bd753b17c08db0feac1c8)
Review URL: https://codereview.chromium.org/2456293002 .
Cr-Commit-Position: refs/branch-heads/2840@{#792}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
M54: Roll FFmpeg 75976ae..cf2d534b
https://chromium.googlesource.com/chromium/third_party/ffmpeg/+log/75976ae..cf2d534b
cf2d534 avformat/mov: Fix potential integer overflow in mov_read_keys
BUG=643948
[email protected]
Review URL: https://codereview.chromium.org/2453323005 .
Cr-Commit-Position: refs/branch-heads/2840@{#791}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.82
Cr-Commit-Position: refs/branch-heads/2840@{#790}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Convert relative paths to absolute paths in iOS test runner
xctests for devices require BUILT_PRODUCTS_DIR to be an absolute path. Might as well just make all paths absolute.
n.b. Inputs to the test runner are always relative paths because this is required by Swarming.
BUG=608537
TBR=huangml
(cherry picked from commit 22203b32bdae9236d23cc89e70772721315f2d1f)
Review-Url: https://codereview.chromium.org/2450133003
Cr-Original-Commit-Position: refs/heads/master@{#427892}
Cr-Commit-Position: refs/branch-heads/2840@{#789}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Support xctests on devices
TestProject is copied from chromium/tools/build/scripts/slave/ios/TestProject.
BUG=608537
(cherry picked from commit 19d5fcc214823ba905cf37650585552027dcd6d0)
Review-Url: https://codereview.chromium.org/2447253003
Cr-Original-Commit-Position: refs/heads/master@{#427816}
Cr-Commit-Position: refs/branch-heads/2840@{#788}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Support xctests on simulators
xctest_utils.py is copied from chromium/tools/build/scripts/slave/ios/xctest_utils.py.
BUG=608537
(cherry picked from commit a02a2039a04b4bafd020ee80ff088be27cf3bdf7)
Review-Url: https://chromiumcodereview.appspot.com/2437953002
Cr-Original-Commit-Position: refs/heads/master@{#426933}
Cr-Commit-Position: refs/branch-heads/2840@{#787}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Fix history nav to a script-injected about:blank frame.
This CL tracks whether the browser process has an about:blank history
item for subframes during a history navigation. If the renderer would
be staying on about:blank, it can skip asking the browser and commit
the initial about:blank page synchronously.
BUG=657896, 639842
TEST=See bug for repro steps.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
[email protected]
Review URL: https://codereview.chromium.org/2438743005 .
Cr-Commit-Position: refs/heads/master@{#426880}
(cherry picked from commit 37c954965f2f221aec294a0a28dfbba1c7543f2a)
Review URL: https://codereview.chromium.org/2454233002 .
Cr-Commit-Position: refs/branch-heads/2840@{#786}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Presumptive fix for LGEmail crash
We found that there is another action mode crash for LG email which
occurs on closing floating paste popup menu from InputConnection method.
BUG=651706
Review-Url: https://chromiumcodereview.appspot.com/2431313006
Cr-Commit-Position: refs/heads/master@{#426402}
(cherry picked from commit 04e2d36acecfc3ee8659cba50e02e64676edf7c7)
Review URL: https://codereview.chromium.org/2453663005 .
Cr-Commit-Position: refs/branch-heads/2840@{#785}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Update Chromoting Mac signing script for new signing system.
This adds flag-style params, which makes calling the script more
flexible, and removes the need to specify the keychain, which is not
compatible with the "split keychains" configuration of the new system,
and not really needed anyhow.
[email protected], [email protected]
BUG=b/31931170
Review-Url: https://codereview.chromium.org/2448273003
Cr-Commit-Position: refs/heads/master@{#427542}
(cherry picked from commit 4b3679a26bad8f470408610bf9bb7ccd46c8610b)
Review URL: https://codereview.chromium.org/2456083002 .
Cr-Commit-Position: refs/branch-heads/2840@{#784}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.
It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns "".
URLFromPasteboard uses SysNSStringToUTF8.
Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can return YES and UTF8String return nil.
BUG=656108
Review-Url: https://chromiumcodereview.appspot.com/2434473005
Cr-Commit-Position: refs/heads/master@{#426463}
(cherry picked from commit e687fefd7265a5e4cc580e73d6e0e028ed52c24c)
Review URL: https://codereview.chromium.org/2445193006 .
Cr-Commit-Position: refs/branch-heads/2840@{#783}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.81
Cr-Commit-Position: refs/branch-heads/2840@{#782}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.80
Cr-Commit-Position: refs/branch-heads/2840@{#781}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Revert "Fix sandbox::PolicyBase leak"
This reverts commit b6a4ff86c730756a73d63cc882ef818fb7818a53
because it breaks Chrome when running as a published app on
Windows Terminal Services or Citrix XenApp.
Original issue's description:
> Fix sandbox::PolicyBase leak
>
> StartSandboxedProcess was missing a Release call, so this was always
> leaking. Use scoped_refptr instead to fix that and prevent it from
> happening in the future.
> [email protected]
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
>
> Committed: https://crrev.com/b6a4ff86c730756a73d63cc882ef818fb7818a53
> Cr-Commit-Position: refs/heads/master@{#417313}
BUG=659026
[email protected],[email protected],[email protected]
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2456573002
Cr-Commit-Position: refs/heads/master@{#427808}
(cherry picked from commit 2bfe4d60b683f05eb7fcb96f9a65d8279923f13f)
Review URL: https://codereview.chromium.org/2453063003 .
Cr-Commit-Position: refs/branch-heads/2840@{#780}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
[DIAL] Make a copy of device id before erasing device from map.
erase() by key takes input param as a const ref. Invoking erase() by
key using data that will be destroyed during the erase() call will
result in undefined behavior.
BUG=656073
Review-Url: https://chromiumcodereview.appspot.com/2436403003
Cr-Commit-Position: refs/heads/master@{#426957}
(cherry picked from commit 2a375e615245ec9cc6ce32f755a5a46564a250e7)
Review URL: https://codereview.chromium.org/2455783002 .
Cr-Commit-Position: refs/branch-heads/2840@{#779}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Add scheme whitelist for content intents
Add a whitelist for content intents sent when the user taps
on an address, email address, or phone number.
BUG=659477
[email protected]
Review URL: https://codereview.chromium.org/2455753002 .
Review-Url: https://codereview.chromium.org/2448363003
Cr-Original-Commit-Position: refs/heads/master@{#427758}
Cr-Commit-Position: refs/branch-heads/2840@{#778}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.79
Cr-Commit-Position: refs/branch-heads/2840@{#777}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.78
Cr-Commit-Position: refs/branch-heads/2840@{#776}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
chromeos: Avoid crash on synchronous suspend readiness call.
Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.
(Unit tests omitted for merge to M54 since they depend on
additional changes.)
BUG=chrome-os-partner:58295,648580
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2403733003
Cr-Commit-Position: refs/heads/master@{#424214}
(cherry picked from commit 2e1f06081912f24add12275fc184f1995011faed)
Review-Url: https://codereview.chromium.org/2451013002
Cr-Commit-Position: refs/branch-heads/2840@{#775}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
chromeos: Fix renderer-freezing race during aborted suspend.
Fix a (long-standing?) race where
chromeos::PowerManagerClient could notify RendererFreezer
that a suspend attempt was imminent *after* already telling
it that the attempt was done.
Also make PowerManagerClient not notify powerd about regular
or dark suspend readiness after it's already seen a
SuspendDone signal.
(Unit tests omitted for merge to M54 since they depend on
additional changes.)
BUG=646912
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2340153002
Cr-Commit-Position: refs/heads/master@{#418887}
(cherry picked from commit 7e1b5a3c7d7ae30ed6ff862f6257ec617da9d742)
Review-Url: https://codereview.chromium.org/2446423002
Cr-Commit-Position: refs/branch-heads/2840@{#774}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Obtain std::string from NSString via base::SysNSStringToUTF8 in password_controller.mm
This is a clean-up avoiding using NSString's UTF8String directly to construct a
std::string, in favour of using base::SysNSStringToUTF8 instead.
BUG=653379
Review-Url: https://codereview.chromium.org/2406833002
Cr-Commit-Position: refs/heads/master@{#424388}
(cherry picked from commit b88c2ab0a6b47e770cf7f3efdde2437491d80850)
Review URL: https://codereview.chromium.org/2444273002 .
Cr-Commit-Position: refs/branch-heads/2840@{#773}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.77
Cr-Commit-Position: refs/branch-heads/2840@{#772}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.76
Cr-Commit-Position: refs/branch-heads/2840@{#771}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.75
Cr-Commit-Position: refs/branch-heads/2840@{#770}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.74
Cr-Commit-Position: refs/branch-heads/2840@{#769}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
[M54] arc: bluetooth: Set advertisement max slot to 1
CTS Verifier want us to also support multiple signal strength
when we declared that multi-advertisement is supported.
Disable multiadvertisement until that is done.
BUG=658387, 658385
TEST=CTS Verifier LE signal strength test won't show up
(spiritual cherry-pick of 4438f8fe974c55d1d8c4f515feab9763aad2b530)
[email protected]
Review URL: https://codereview.chromium.org/2444673002 .
Cr-Commit-Position: refs/branch-heads/2840@{#768}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.73
Cr-Commit-Position: refs/branch-heads/2840@{#767}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.72
Cr-Commit-Position: refs/branch-heads/2840@{#766}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.71
Cr-Commit-Position: refs/branch-heads/2840@{#765}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
[M54] Fix build.
[email protected]
BUG=648366
Review URL: https://codereview.chromium.org/2438673002 .
Cr-Commit-Position: refs/branch-heads/2840@{#764}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.70
Cr-Commit-Position: refs/branch-heads/2840@{#763}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
HSTS preload list removals for Chrome 55.
eyyit.com:
> I jumped the gun on hsts preloading and now have a subdomain that needs to
> read xml feeds from non-https sites. This HSTS preload including subdomains
> broke that. Instead of waiting for the feeds to update their site to https,
> I'd rather get the removal process started soon so I have some options.
svallee.fr:
> • home.svallee.fr (many services, not all with HTTPS available)
vjirovsky.cz:
> axure.vjirovsky.cz – it’s branded (CNAME) version of axshare.com and they are
> not able to have certificate for axure.vjirovsky.cz
tradeacademy.in:
> list.tradeacademy.in -> We are using this domain for our newsletter
> application & we don't have Wildcard SSL certificate so whenever we open
> list.tradeacademy.in it goes to HTTPS in chrome.
almeria.fr:
> store.almeria.fr – problem with our website supplier
almeria-si.fr:
> store.almeria-si.fr – this site is managed by a partner, and we are not ready
> to migrate to https.
vozp.cz:
> • maps.vozp.cz – subsite dont using SSL
> • intranet.vozp.cz – internal application
> • helpdesk.vozp.cz – internal application
zen-trader.com:
> We cannot support HTTPS on the following subdomains:
> • status - Not under our control (third party server)
> • email - Not under our control (third party server)
> • clk - Not under our control (third party server)
> • mailsrv - Not under our control (third party server)
bratteng.me:
> dell.bratteng.me - some of the ports other than 80 and 443 does not support
> https yet
soleus.nu:
> We are a non-profit hosting association, and almost all subdomains are
> assigned to members (with their own vps and hosting services).
chrishamper.com:
> I had enabled the HSTS header with the "preload" directive on my domain while
> following an online guide related to HSTS, which didn't explain the meaning or
> repercussions of that directive. It is now causing much trouble when
> attempting to do development work using subdomains I'm spinning up as needed.
elisa.ee:
> tanama.elisa.ee – it needs to be opened with HTTP
mijailovic.net:
> • www.mijailovic.net - I’m moving my website from custom server to GitHub
> pages, but GitHub doesn’t support https on their custom subdomains.
skyo.com:
> • Skyo.com/api/ - Most Clients using API part of our site only support weak
> SSLv3 or dont support SSL/TLS at all. This had a huge impact on our business
> and we have found temporary ways around this until we can get off the preload
> list. We eventually will add the main site, skyo.com (www.skyo.com), back to
> HSTS but our backend Admin and API sections we will avoid the change due to
> too many clients not running modern systems.
mitell.jp:
> • [staging.mitell.jp, test.mitell.jp] - They are for test and our project
> cannot apply SSL for test sites.
callcap.com:
> We have several callcap.com subdomains that are used internally only that
> cannot work with HTTPS. The preload directive was configured by mistake on our
> webservers but has since been removed.
BUG=527947, 655854
[email protected]
Review URL: https://codereview.chromium.org/2306423004 .
Cr-Commit-Position: refs/heads/master@{#423678}
(cherry picked from commit bf314ad606b8153e52f64068e5550c61a320cdb3)
Review URL: https://codereview.chromium.org/2431163006 .
Cr-Commit-Position: refs/branch-heads/2840@{#762}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Use the Google report-uri for badssl Expect-CT site
This change goes along with
https://github.com/chromium/badssl.com/pull/206, which adds the
preloaded-expect-ct.badssl.com to badssl.com and serves the Expect-CT
header with no SCTs. Along with this CL, we'll get an easy way to
manually test Expect-CT end-to-end, by visiting
preloaded-expect-ct.badssl.com in Chrome and seeing that a report gets
generated and logged on the server side.
BUG=655854
Review-Url: https://codereview.chromium.org/2336373002
Cr-Commit-Position: refs/heads/master@{#418425}
(cherry picked from commit 960fde37768267fb16f8b7ffd7bc4d4bac10bb4c)
Review URL: https://codereview.chromium.org/2436523003 .
Cr-Commit-Position: refs/branch-heads/2840@{#761}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Incrementing VERSION to 54.0.2840.69
Cr-Commit-Position: refs/branch-heads/2840@{#760}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
Relax '*' in CSPSourceList to match the FTP protocol.
'*' should match 'ftp://whatever/file.pdf' because 'ftp' is a
network scheme under the CSP specification.
BUG=656956
Review-Url: https://codereview.chromium.org/2425683006
Cr-Commit-Position: refs/heads/master@{#426069}
(cherry picked from commit 79209ba0cefc48a9fdedf602658e84ddf9b8879b)
Review URL: https://codereview.chromium.org/2437803002 .
Cr-Commit-Position: refs/branch-heads/2840@{#759}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
[Merge-54][net/auth] Don't abort network transaction over non-permanent auth errors.
A multi-round authentication handshake may break partway through with an
error that indicates that the credentials used were invalid. With GSSAPI
we've seen this come up when the underlying library attempted to
authenticate against an endpoint even though no valid credentials were
available to finish the handshake. On Windows, this is now possible
since KB3189866.
Due to the fact that the underlying libraries attempt to start the
authentication handshake, the HttpNetworkTransaction proceeds past the
point where the HttpAuthController accepts the challenge and picks an
identity to use for the handshake. However, when the time comes to
generate a token, which happens just prior to sending the next HTTP
request, the HttpAuthController fails the operation with an
ERR_INVALID_AUTH_CREDENTIALS error. The state machine can't proceed past
this error and the user ends up looking at an error page.
e.g.:
C->S : GET something
S->C : HTTP/1.1 401 You shall not pass
WWW-Authenticate: Negotiate
C->[underlying authentication library, hereafter called UAL] :
"Can you authenticate to example.com?"
[UAL]->C: "Sure thing. Here's a token to get started : [token1]"
C->S : GET something
Authorization: Negotiate [token1]
S->C : HTTP/1.1 401 Need moar authentication
WWW-Authenticate: Negotiate [token2]
C->[UAL]: "example.com gave us [token2]. What should we do now?"
[UAL]->C: "LOL. Who knows? Look a squirrel!"
C: ...
C: Shows ERR_INVALID_AUTH_CREDENTIALS to the user.
This should be considered a permanent error if there is actually no
other way to proceed. However, if there are other authentication schemes
to try, or if the initial authentication attempt was made using ambient
credentials and the scheme supports explicit credentials, then those
should be attempted next.
This CL changes the response of the network stack at the final step to
restart the network transaction by sending a request with no
Authorization header. This signals to the server that the client is
restarting the authentication handshake. It can then start over at which
point the client can attempt to use a different identity or a different
authentication scheme to proceed.
R=mmenke
BUG=648366
Review-Url: https://codereview.chromium.org/2382293004
Cr-Commit-Position: refs/heads/master@{#424563}
(cherry picked from commit e2257db89c38e2846d27a6de41a1ed4804ee5cab)
Review URL: https://codereview.chromium.org/2432873003 .
Cr-Commit-Position: refs/branch-heads/2840@{#758}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
[Merge-M54] [net] clang-format HttpNetworkTransactionTest.GenerateAuthToken test.
This is a pretty big test with a lot of test cases. clang-format pretty
much reformats the entire test beyond recognition. Subsequent patches
that may touch this test will be unreviewable if they also include the
formatting changes. Uploading the formatting changes separately.
BUG=648366
Review-Url: https://codereview.chromium.org/2385883002
Cr-Commit-Position: refs/heads/master@{#422429}
(cherry picked from commit c930761972fa8611069d0e55e3f45dd0c56c2d54)
Review URL: https://codereview.chromium.org/2431193004 .
Cr-Commit-Position: refs/branch-heads/2840@{#757}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
[Merge to M54]Adding experimental flag for enumerating audio devices on ChromeOS, default disabled
BUG=651512
[email protected], [email protected]
TEST=tested on device, default state is restoring to m53 behavior; if enabled in chrome://flags, the added feature will be shown.
Review-Url: https://codereview.chromium.org/2427493003
Cr-Commit-Position: refs/heads/master@{#426058}
(cherry picked from commit e993ec31e3b80b34b2279017db6e6b049d862927)
Review URL: https://codereview.chromium.org/2435803002 .
Cr-Commit-Position: refs/branch-heads/2840@{#756}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
