| commit | 99479f6b06f315efa35a9a5f8f6b9832db7276ac | [log] [tgz] |
|---|---|---|
| author | Alan Zhao <[email protected]> | Fri Aug 26 23:03:00 2022 |
| committer | Chromium LUCI CQ <[email protected]> | Fri Aug 26 23:03:00 2022 |
| tree | 62c37de7623fc2eccd000a47ec07eb50dec37ed8 | |
| parent | 43f640710abf43e2282bcbd099811ecfe0d4d503 [diff] |
[libc++] Enable assertions on all builds and add a handler for non-Windows release builds This is mostly a reland of commit 84d5f89427e270d1830c359f9df082ff48709317 with some changes to resolve issues that resulted in the original commit being rolled back. The main difference in this commit is that on Windows, we enable assertions for libc++, but we do not use our custom handler for nondebug builds as Windows doesn't support weak symbols (crbug.com/1353463), which are required for the libc++ assertion handler override mechanism. Additional changes to get this to work * Define _LIBCPP_AVAILABILITY_CUSTOM_VERBOSE_ABORT_PROVIDED. * Disable LibcppHardeningTest.Assertions on Android (crbug.com/1353549). * Comment fixes. Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:mac11-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-asan,win7-rel Cq-Include-Trybots: chromium/try:android-official,fuchsia-official Cq-Include-Trybots: chromium/try:mac-official,linux-official Cq-Include-Trybots: chromium/try:win-official,win32-official Cq-Include-Trybots: chromium/try:linux-swangle-try-x64,win-swangle-try-x86 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,linux-chrome,mac-chrome Cq-Include-Trybots: chrome/try:linux-pgo,mac-pgo,win32-pgo,win64-pgo Binary-Size: Size increase due to added assertion checks in libc++ Fuchsia-Binary-Size: Size increase due to added assertion checks in libc++ Bug: 1335422,1353463,1353549 Change-Id: Ia282c7cc27b170c288a3c2d1f508e11be4d356ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833545 Commit-Queue: Alan Zhao <[email protected]> Reviewed-by: Nico Weber <[email protected]> Cr-Commit-Position: refs/heads/main@{#1040015}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.