Attachment 8956499 Details for Bug 1442804

[patch] heap write analysis: explicitly whitelist stringbuffer canary field

base-53ea5bc4d93e (text/plain), 1.09 KB, created by Steve Fink [:sfink] [:s:]

(hide)

Description:

Filename:

MIME Type:

Creator: Steve Fink [:sfink] [:s:]

Size: 1.09 KB

patch

obsolete

># HG changeset patch
># User Steve Fink <sfink@mozilla.com>
># Date 1520354682 28800
>#      Tue Mar 06 08:44:42 2018 -0800
># Node ID 9242431f5d1489549003f61270fd397300555e52
># Parent  670cf6210c0f2a5ffe7d383a429781f081ee4efb
>heap write analysis: explicitly whitelist stringbuffer canary field
>
>diff --git a/js/src/devtools/rootAnalysis/analyzeHeapWrites.js b/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
>--- a/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
>+++ b/js/src/devtools/rootAnalysis/analyzeHeapWrites.js
>@@ -292,16 +292,20 @@ function checkFieldWrite(entry, location
>         // improve the analysis to handle these.
>         if (/already_AddRefed.*?.mRawPtr/.test(field))
>             return;
>         if (/nsCOMPtr<.*?>.mRawPtr/.test(field))
>             return;
> 
>         if (/\bThreadLocal<\b/.test(field))
>             return;
>+
>+        // Debugging check for string corruption.
>+        if (field == "nsStringBuffer.mCanary")
>+            return;
>     }
> 
>     var str = "";
>     for (var field of fields)
>         str += " " + field;
> 
>     dumpError(entry, location, "Field write" + str);
> }

Flags:

bholley: review+

Actions: View | Diff | Review

Attachments on bug 1442804: 8955702 | 8955721 | 8956498 | 8956499 | 8956500 | 8956502

Bugzilla

Quick Search

Attachment 8956499 Details for Bug 1442804