Bugzilla

Description: Switch to WeakPtr

Filename:

MIME Type:

Creator: Andreas Pehrson [:pehrsons]

Size: 725 bytes

patch

>changeset: 448840:94724d3dfacb >bookmark: bug_1419363 >tag: tip >user: Andreas Pehrson <pehrsons@mozilla.com> >date: Thu Nov 30 14:49:06 2017 +0100 >summary: Bug 1419363 - Switch to WeakPtr. r?jib > >diff --git a/dom/html/HTMLMediaElement.cpp b/dom/html/HTMLMediaElement.cpp >--- a/dom/html/HTMLMediaElement.cpp >+++ b/dom/html/HTMLMediaElement.cpp >@@ -5237,11 +5237,14 @@ public: > { > NS_ASSERTION(NS_IsMainThread(), "Should be on main thread."); > >+ if (!mElement) { >+ return; >+ } > mElement->NotifyMediaStreamTracksAvailable(aStream); > } > > private: >- HTMLMediaElement* mElement; >+ WeakPtr<HTMLMediaElement> mElement; > }; > > class HTMLMediaElement::MediaStreamTrackListener : >

Flags:

jib: review+
gchang: approval-mozilla-beta+
gchang: approval-mozilla-esr52+
abillings: sec-approval+