Attachment 8840079 Details for Bug 1315248

[patch] bug1315248_part2.patch

bug1315248_part2.patch (text/plain), 2.42 KB, created by Nils Ohlmeier [:drno]

(hide)

Description:

Filename:

MIME Type:

Creator: Nils Ohlmeier [:drno]

Size: 2.42 KB

patch

obsolete

>diff --git a/dom/network/UDPSocketParent.cpp b/dom/network/UDPSocketParent.cpp
>--- a/dom/network/UDPSocketParent.cpp
>+++ b/dom/network/UDPSocketParent.cpp
>@@ -239,17 +239,17 @@ static void CheckSTSThread()
> // Proxy the Connect() request to the STS thread, since it may block and
> // should be done there.
> mozilla::ipc::IPCResult
> UDPSocketParent::RecvConnect(const UDPAddressInfo& aAddressInfo)
> {
>   nsCOMPtr<nsIEventTarget> thread(NS_GetCurrentThread());
>   Unused <<
>     NS_WARN_IF(NS_FAILED(GetSTSThread()->Dispatch(WrapRunnable(
>-                                                    this,
>+                                                    RefPtr<UDPSocketParent>(this),
>                                                     &UDPSocketParent::DoConnect,
>                                                     mSocket,
>                                                     thread,
>                                                     aAddressInfo),
>                                                   NS_DISPATCH_NORMAL)));
>   return IPC_OK();
> }
> 
>@@ -261,17 +261,17 @@ UDPSocketParent::DoSendConnectResponse(c
> }
> 
> void
> UDPSocketParent::SendConnectResponse(nsIEventTarget *aThread,
>                                      const UDPAddressInfo& aAddressInfo)
> {
>   Unused <<
>     NS_WARN_IF(NS_FAILED(aThread->Dispatch(WrapRunnable(
>-                                             this,
>+                                             RefPtr<UDPSocketParent>(this),
>                                              &UDPSocketParent::DoSendConnectResponse,
>                                              aAddressInfo),
>                                            NS_DISPATCH_NORMAL)));
> }
> 
> // Runs on STS thread
> void
> UDPSocketParent::DoConnect(nsCOMPtr<nsIUDPSocket>& aSocket,
>@@ -581,16 +581,16 @@ UDPSocketParent::FireInternalError(uint3
> 
> void
> UDPSocketParent::SendInternalError(nsIEventTarget *aThread,
>                                    uint32_t aLineNo)
> {
>   UDPSOCKET_LOG(("SendInternalError: %u", aLineNo));
>   Unused <<
>     NS_WARN_IF(NS_FAILED(aThread->Dispatch(WrapRunnable(
>-                                             this,
>+                                             RefPtr<UDPSocketParent>(this),
>                                              &UDPSocketParent::FireInternalError,
>                                              aLineNo),
>                                            NS_DISPATCH_NORMAL)));
> }
> 
> } // namespace dom
> } // namespace mozilla

Flags:

jesup: review+
gchang: approval-mozilla-aurora+
abillings: sec-approval+

Actions: View | Diff | Review

Attachments on bug 1315248: 8836279 | 8840079 | 8840187

Bugzilla

Quick Search

Attachment 8840079 Details for Bug 1315248