Set 'text-align: start' on ':host' in moz-message-bar.css
Categories
(Toolkit :: UI Widgets, defect, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: jules, Assigned: camilledavisdev, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=css])
Attachments
(2 files)
wrong text alignment due to parent setting text alignment and the message bar not.png
We need to specify text-align: start on :host in moz-message-bar.css so that it won't inherit a parent or ancestor element style that sets a different text alignment. Including a screenshot of plugins of what's happening today since they justify the text with center.
|
||
Comment 1•8 months ago
|
||
(In reply to Jules Simplicio [:jules] from comment #0)
Created attachment 9356474 [details]
wrong text alignment due to parent setting text alignment and the message bar not.pngWe need to specify
text-align: starton:hostinmoz-message-bar.cssso that it won't inherit a parent or ancestor element style that sets a different text alignment. Including a screenshot of plugins of what's happening today since they justify the text with center.
Hi please can i be assigned this bug ? and also where can i find the file for this bug ?
|
Reporter | |
Comment 2•8 months ago
•
|
||
(In reply to peterodejobi9 from comment #1)
(In reply to Jules Simplicio [:jules] from comment #0)
Created attachment 9356474 [details]
wrong text alignment due to parent setting text alignment and the message bar not.pngWe need to specify
text-align: starton:hostinmoz-message-bar.cssso that it won't inherit a parent or ancestor element style that sets a different text alignment. Including a screenshot of plugins of what's happening today since they justify the text with center.Hi please can i be assigned this bug ? and also where can i find the file for this bug ?
Hey there,
Here's the file.
I also went ahead and assigned you to this bug.
Let me know if you need any further help!
|
|
||
Comment 3•8 months ago
|
||
On Nightly how do i navigate to this part of the UI ?
|
|
Reporter | |
Comment 4•8 months ago
|
||
(In reply to peterodejobi9 from comment #3)
On Nightly how do i navigate to this part of the UI ?
Hey there, you can see that in about:plugins
|
|
Reporter | |
Comment 5•8 months ago
|
||
Hey peterodejobi9, just wanted to follow up and ask if you need any help.
|
|
||
Comment 6•8 months ago
|
||
(In reply to Jules Simplicio [:jules] from comment #5)
Hey peterodejobi9, just wanted to follow up and ask if you need any help.
Oh No thank i'll send in my patch for review
|
|
Reporter | |
Comment 7•7 months ago
•
|
||
Our about:plugins code got removed but this work is still valid so we can avoid this happening in the future.
Hey peterodejobi9 let me know if you need any help with the patch :)
|
||
Updated•7 months ago
|
|
|
||
Comment 8•7 months ago
|
||
Going to unassign for now @peterodejobi9 but feel free to post your patch and the bug will automatically be assigned to you again. If you need any assistance then feel free to comment here and request information from Jules.
Thanks!
|
||
Updated•2 months ago
|
|
|
||
Updated•2 months ago
|
|
Assignee | |
Comment 10•2 months ago
|
||
Phabricator says it needs a testing tag... should I add one? (And if so which one?)
|
|
Reporter | |
Comment 11•2 months ago
|
||
Hey Camille, I added a tag for you. I can also help with landing this.
|
||
Comment 12•2 months ago
|
||
Pushed by jsimplicio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11a2a9133079 Add text-align: start to moz-message-bar so it doesn't inherit alignment from parent. r=desktop-theme-reviewers,reusable-components-reviewers,jules
|
||
Comment 13•2 months ago
|
||
| bugherder | ||
Description
•