[Debugger] Change Watch Expressions input field placeholder value
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox125 fixed)
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: luc4leone, Assigned: artemmanusenkov)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.116 Safari/537.36
Steps to reproduce:
In Watch Expressions the input field placeholder is "Add watch expression". A better value seems to be "Add expression".
Details of the discussion: https://github.com/firefox-devtools/ux/issues/102
|
||
Comment 1•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
||
Updated•4 years ago
|
|
||
Updated•2 years ago
|
| Comment hidden (spam) |
|
||
Updated•1 year ago
|
|
||
Comment 3•1 year ago
|
||
Hello, I wanted to take this one.
But then I looked at Chromium. They don't have a placeholder in the Watch section, but they have an empty state placeholder saying: "No watch expressions".
In FF docs it's also said: "To remove a watch expression, select the X button that appears when you hover over a line."
From these facts, I got the feeling that "watch expression", though sounds weird to me looks like a term, or just that no one cares much about naming.
I checked the issue linked, there is not much context about the renaming itself.
So there are two ways:
- Leave everything as is and close the issue
- Rename the placeholder to "Add expression", check for other places where "watch expression" is used, and consider changing it to "expression" too.
|
||
Comment 4•6 months ago
|
||
I've attempted a patch on this. Is there anyone who can walk me through the review and submittal process?
Thanks,
|
|
||
Comment 5•6 months ago
|
||
|
||
Updated•6 months ago
|
|
|
||
Updated•6 months ago
|
|
|
||
Comment 6•4 months ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
|
Assignee | |
Comment 7•4 months ago
|
||
Hello! I'd like to take over applying the review suggestions mentioned here https://phabricator.services.mozilla.com/D197316, since it's been 2 months and they are trivial
I believe i need to commandeer the revision, but i don't have that action available to me, i need some guidance
|
|
||
Comment 8•4 months ago
|
||
(In reply to Amanushenkov10 from comment #7)
Hello! I'd like to take over applying the review suggestions mentioned here https://phabricator.services.mozilla.com/D197316, since it's been 2 months and they are trivial
Sure, thanks for offering help
I believe i need to commandeer the revision, but i don't have that action available to me, i need some guidance
I think it might be better for you to create a brand new revision on phabricator singe pgiovanni1234 is not responding and the patch needed some updates. https://phabricator.services.mozilla.com/D197316 is also very small, so I think it's okay if you "steal" it and move it to the finish line.
|
|
Assignee | |
Comment 9•4 months ago
|
||
|
|
||
Updated•4 months ago
|
|
||
Comment 10•4 months ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f76e71f5608 Change Watch expressions input field placeholder from "Add watch expression" to "Add expression". r=nchevobbe,devtools-reviewers
|
||
Comment 11•4 months ago
|
||
| bugherder | ||
Description
•