| commit | c219dfc78c4e78908ac59eeb136815551adb25bb | [log] [tgz] |
|---|---|---|
| author | Ian Lake <[email protected]> | Wed Oct 12 17:15:13 2022 +0000 |
| committer | Ian Lake <[email protected]> | Wed Oct 12 20:58:21 2022 +0000 |
| tree | f1e2c70e51cee944d7dbeab4b40968dd87bff37c | |
| parent | f9fb643c6b48ee1dee4163f2812b74ee4705204f [diff] |
Fix removing state in onCleared() When you call popBackStack() or hit the system back button, the NavController will instantly update its own state. This update triggers the NavHost to update the visible destination, crossfading / running transitions between the previous destination and the new destination. This async process ends with the previous destination leaving composition. At that point and only at that point, can the NavController completely destroy any state associated with that destination. This includes clearing out any ViewModels assocaited with that destination. This means that the previous approach of clearing out the reference to the SaveableStateHolder in a DisposableEffect was too early - when the onCleared() of our BackStackEntryIdViewModel was called, the removal of Compose state was never able to actually happen. By instead keeping a WeakReference to the SaveableStateHolder, we get two properties: - The SaveableStateHolder is available when onCleared() is called - The ViewModel does not store a reference to a SaveableStateHolder across configuration changes (i.e., does not leak the SaveableStateHolder) Relnote: "Fixed an issue where saved Compose state (e.g., usages of `rememberSaveable`) were not being forgotten and removed when a destination was popped off the back stack." Test: Leak regression test still passes, tested in sample BUG: 245355393 Change-Id: I649492142419b56d9ef5ab768a2cfe7662f026e2
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), jcenter(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.