commit | c1eb02a8e0904d91f5a1ef7fceeeadaa818f79b9 | [log] [tgz] |
---|---|---|
author | Yigit Boyar <[email protected]> | Thu Jan 13 16:11:00 2022 -0800 |
committer | Yigit Boyar <[email protected]> | Fri Jan 21 00:15:08 2022 +0000 |
tree | 3a02ef0f2a6b3ab0d3c115ea8d56d00a1fb02ba3 | |
parent | ca17b986c49e7b9ba0d04340d3cf8c0741a35297 [diff] |
Use method name when partitioning for overrides Kotlin methods / accessors can be annotated with JvmName to change their name in the byte code. This is designed to be invisible from kotlin code. As such, it is also not allowed on overriding methods or open methods. Unfortunately, it is also possible for the developer to suppress that error via @Suppress("INAPPLICABLE_JVM_NAME"). This CL updates XProcessing to basically ignore that annotation for overrides. The practical impact of this is a 30x performance gain for getAllMethods since we don't need to resolve method types to check for overrides. Upon discussions with the Kotlin Compiler team, their feedback is that it is fair to ignore that annotation since the behavior of the compiler gets really complicated when used along with method overrides. Furthermore, user suppressed an error hence they cannot really expect everything to work as usual. I've added a warning for Dao and Database methods that checks if the method is annotated with JvmName, and if so, prints a warning that cannot be suppressed. Also added tests for cases where it happens to work so that we know if we further break it :) . Measurements: (when it was a config, but should be relatively the same) androidx.room.compiler.processing.profiling.GetMethodsScenarioTest > allMethods_filterOutInline STANDARD_OUT Stats(min=69.319659ms, max=145.664166ms, avg=91.519145ms, mean=70.507303ms, allMeasurements=[88.612249ms, 78.264850ms, 88.811043ms, 70.880497ms, 71.694948ms, 69.319659ms, 145.664166ms, 90.055662ms, 130.070210ms, 81.818174ms]) androidx.room.compiler.processing.profiling.GetMethodsScenarioTest > allMethods_filterOutInline PASSED androidx.room.compiler.processing.profiling.GetMethodsScenarioTest > allMethods_keepInline STANDARD_OUT Stats(min=1.643961ms, max=3.542199ms, avg=2.149422ms, mean=2.636825ms, allMeasurements=[2.081342ms, 1.933364ms, 1.709868ms, 1.679751ms, 3.542199ms, 1.731452ms, 1.643961ms, 2.329103ms, 1.686483ms, 3.156701ms]) Bug: 160322705 Test: GetMethodsSecenarioTest, XTypeElementTest, DaoProcessorTest, Test: DatabaseProcessorTest, JvmNameInDaoTest.kt Merged-In: I0e6415e5a17f378f7009adff53f1c9e65930fd7d Change-Id: I0e6415e5a17f378f7009adff53f1c9e65930fd7d
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.*
package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
NOTE: You will need to use Linux or Mac OS. Building under Windows is not currently supported.
repo
(Repo is a tool that makes it easier to work with Git in the context of Android. For more information about Repo, see the Repo Command Reference)mkdir ~/bin PATH=~/bin:$PATH curl https://storage.googleapis.com/git-repo-downloads/repo > ~/bin/repo chmod a+x ~/bin/repo
git config --global user.name "Your Name" git config --global user.email "[email protected]"
mkdir androidx-main cd androidx-main
repo
command to initialize the repository.repo init -u https://android.googlesource.com/platform/manifest -b androidx-main --partial-clone --clone-filter=blob:limit=10M
repo sync -j8 -c
You will use this command to sync your checkout in the future - it’s similar to git fetch
To open the project with the specific version of Android Studio recommended for developing:
cd path/to/checkout/frameworks/support/ ANDROIDX_PROJECTS=MAIN ./gradlew studio
and accept the license agreement when prompted. Now you're ready to edit, run, and test!
You can also the following sets of projects: ALL
, MAIN
, COMPOSE
, or FLAN
If you get “Unregistered VCS root detected” click “Add root” to enable git integration for Android Studio.
If you see any warnings (red underlines) run Build > Clean Project
.
You can do most of your work from Android Studio, however you can also build the full AndroidX library from command line:
cd path/to/checkout/frameworks/support/ ./gradlew createArchive
You can build maven artifacts locally, and test them directly in your app:
./gradlew createArchive
And put the following at the top of your ‘repositories’ property in your project build.gradle
file:
maven { url '/path/to/checkout/out/androidx/build/support_repo/' }
NOTE: In order to see your changes in the project, you might need to clean your build (Build > Clean Project
in Android Studio or run ./gradlew clean
).
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Run FooBarTest
Run androidx.foobar
The AndroidX repository has a set of Android applications that exercise AndroidX code. These applications can be useful when you want to debug a real running application, or reproduce a problem interactively, before writing test code.
These applications are named either <libraryname>-integration-tests-testapp
, or support-\*-demos
(e.g. support-v4-demos
or support-leanback-demos
). You can run them by clicking Run > Run ...
and choosing the desired application.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
cd path/to/checkout/frameworks/support/ repo start my_branch_name . # make needed modifications... git commit -a repo upload --current-branch .
If you see the following prompt, choose always
:
Run hook scripts from https://android.googlesource.com/platform/manifest (yes/always/NO)?
If the upload succeeds, you'll see output like:
remote: remote: New Changes: remote: https://android-review.googlesource.com/c/platform/frameworks/support/+/720062 Further README updates remote:
To edit your change, use git commit --amend
, and re-upload.
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal
and prebuilts/androidx/external
directories in your checkout. All the dependencies in these directories are also available from google()
, jcenter()
, or mavenCentral()
. We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.