| commit | a4cc3154bbebb7e3fce6c3e8f72ff933c4990dd3 | [log] [tgz] |
|---|---|---|
| author | Andrey Kulikov <[email protected]> | Wed Aug 16 15:57:44 2023 +0100 |
| committer | Android Build Coastguard Worker <[email protected]> | Mon Aug 21 16:51:09 2023 +0000 |
| tree | f0c78b6f1bf1f31d8ba5676e63fcc8da7a297fd3 | |
| parent | a7c787e83b3dba8c2b9ad15d8e7617dfde488994 [diff] |
Make sure Modifier.pointerInput() uses the latest lambda after reuse
One of the recommended patterns for using Modifier.pointerInput() is:
val currentValue by rememberUpdatedState(value)
Modifier.pointerInput(Unit) {
// use currentValue
}
However after we migrated this modifier to Modifier.Node this pattern is broken after reuse happens as we do not call update when the modifier element didn't change and the key representing the element identity is Unit, which didn't change. When lambda changes we don't update the modifier. Technically correct would be to recommend our users to write
val currentValueState = rememberUpdatedState(value)
Modifier.pointerInput(currentValueState) {
// use currentValueState.value
}
instead, however we can't really expect users to write such code as it is overcomplicated and counterintuitive.
This case is quite unique and we don't have any other modifiers like that so we decided to workaround it right in the Modifier.Node system for this type of modifier. After this change the update will be called for this modifier after reuse even when the input didn't change. If in future we will figure out there are other use cases like that we will consider adding a public api to solve the same issue from other implementations.
Fixes: 293820085
Test: SuspendingPointerInputFilterTest
(cherry picked from https://android-review.googlesource.com/q/commit:ed57dabc72105fb86d8bf0d646662b6b00c96dd8)
(cherry picked from https://android-review.googlesource.com/q/commit:238ab59c2ca4a29dc5e05a29f22c09bcbc477d93)
Merged-In: Iee6f3fac87d87106791a33ea887a478df86cfce1
Change-Id: Iee6f3fac87d87106791a33ea887a478df86cfce1
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.