commit | 82873e94d324ac936f42e77ab38a40d04ff2598e | [log] [tgz] |
---|---|---|
author | Sergey Vasilinets <[email protected]> | Sat Feb 11 11:31:26 2023 +0000 |
committer | Sergey Vasilinets <[email protected]> | Sat Feb 11 11:32:52 2023 +0000 |
tree | 4164945aa56ef348bc265047b514cdca70f8f0bc | |
parent | 97701563309ff679ac308284bef4d49d8b8113e2 [diff] |
Fix race in TestScheduler ``` val request = PeriodicWorkRequestBuilder<Worker>(10, Days).build() wm.enqueue(request).result.get() driver.setAllConstraints(request.id) ``` Even though request doesn't have constraints, `setAllConstraints` triggers second round of execution. So what was happening: 1. `wm.enqueue(request).result.get()` was resulting in the posting WorkerWrapper to serial executor. Data for it was removed from `pendingWorkStates`. 2. `setAllConstraints()`` initialized `InternalWorkState` from scratch, `periodDelayMet` was initialized to `true`, because `periodCount` is 0, because WorkerWrapper hasn't been executed just yet. 3. Once the first run of worker finishes, `TestScheduler.schedule` was called. After "2." this call triggers second round of execution because `periodDelayMet = true` In this CL we don't read `periodCount` too early, now we simply track calls to `setAllConstraints`, `setInitialDelayMet`, `setPeriodDelayMet` and ``periodCount` is read just in time before making a request to `Processor` fix: 268497545 Test: TestSchedulerRealExecutorTest#testSetAllConstraintsDontTriggerSecondRun Change-Id: Ibde3f4fa062472be99e8e2b310cac4f07015124c
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.*
package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal
and prebuilts/androidx/external
directories in your checkout. All the dependencies in these directories are also available from google()
, jcenter()
, or mavenCentral()
. We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.