Chromium Main Console
Legend: | Passed | Failed | Running | Exception |
Implementation for BlindSignMessageAndroidImpl and refactoring client auth into an interface.
BlindSignMessageAndroidImpl requests to bind to the GmsCore IP Protection Service using the Auth Client Wrapper around the Java IpProtectionAuthClient. The DoRequest method will use the client auth to call the GmsCore bound service to attach the OAuth token and intermediate requests to Phosphor.
Bug: 331619233
Change-Id: Ibb1a04d7222cf2f52020039ce197bb37c7cb4bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5501301
Reviewed-by: Danil Chapovalov <[email protected]>
Commit-Queue: Ciara McMullin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312777}
Remove unused function from FetchContext
Bug: 41496436
Change-Id: I465e04779d212d830850b997edca93d06e49130e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5610637
Commit-Queue: Nidhi Jaju <[email protected]>
Reviewed-by: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312776}
Updating trunk VERSION from 6532.0 to 6533.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: Idb0c63eba4078e462150c4fd341057b70274500e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5615470
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1312775}
[sync] Post task when registering synthetic trials
SyncClient's implementation can run into an infinite recursion if
`RegisterTrustedVaultAutoUpgradeSyntheticFieldTrial()` leads to
exercising the factory that constructs SyncServiceImpl.
This scenario is known to be reachable on iOS as per linked bug, so the
safest and most future-proof approach is to use task-posting to slightly
delay the registration of synthetic field trials, which guarantees that
the construction of SyncService is completed at the time.
Change-Id: I0c0ed22fdce2479e444640caad1c896a7d4021ea
Fixed: 345514506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5607959
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Ankush Singh <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312774}
Revert "Temporarily return ios-fieldtrial-rel to targeting Mac-13|Mac-14 until bots upgrade"
This reverts commit 4b3d44bc41aa76afa3dd5b30a62b4ac878492155.
Reason for revert: Bots have now been upgraded to Mac-14
Original change's description:
> Temporarily return ios-fieldtrial-rel to targeting Mac-13|Mac-14 until bots upgrade
>
> Bug: 345748239
> Change-Id: Ib336a58a1ba9ee9e1a89a773392401976795fde9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5605637
> Reviewed-by: Yue She <[email protected]>
> Commit-Queue: Will Yeager <[email protected]>
> Reviewed-by: Zhaoyang Li <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1312203}
Bug: 345748239
Change-Id: I131a73b79beb0b306d3d1c54809c709abe7026f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5615210
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Yue She <[email protected]>
Commit-Queue: Will Yeager <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312773}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1718020694-d6c763a069f6abde1d4df6cb96b865ec207a24c5-8003dfad08b6aefbd8447edfc2704e442f0c3bee.profdata to chrome-mac-arm-main-1718027784-334776a065646613a7403027142be331e7bee2b1-21923f9629f23105bfe8e4417bc295d236b10068.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ic6c74166ed5d3d92938d1ab328601d95712f2ddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614772
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312772}
RubyLB: Add a DumpAccessibilityTree testcase
This CL adds a line-broken <ruby> to ruby.html.
Bug: 324111880
Change-Id: I8e638f84278d27f2bd6d0d2062f99677d861b6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5612830
Reviewed-by: Aaron Leventhal <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312771}
[Unop2][Android] Fix failing UpgradePromoIntegrationTest
We follow what is done in the FRE tests https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunActivitySigninAndSyncTest.java;l=623;drc=26493606f274b98963565f2c992bd490be20326f
In the dry run, I added the failing test config (android-12l-x64-dbg) to the CQ trybots and the CL passed the run, so hopefully this will fix the test.
Change-Id: I53e4137c72af3d365a1c96d2de910c6858b30ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5613510
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Samar Chehade-Lepleux <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Auto-Submit: Samar Chehade-Lepleux <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312770}
[Android TRM] V2 Model Training: Allow negative request_id.
Earlier CLs (crrev.com/c/5598499 and crrev.com/c5598515) to support V2
model training feedback path (via calls to RecordAction()) required
|request_id| to be non-negative. This restriction turned out to be
extraneous, and caused missed calls to RecordAction(). This CL fixes the
issue by removing the constraints.
Also update TabResumptionModuleMediatorUnitTest to specify |requestId|
values that may be negative. Replacing |requestId| generation with
specification via List in addFakeTrainingInfo().
Bug: 344949868
Change-Id: Iafc6fd7555586eee13084a57b6d97705bff650b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5611754
Code-Coverage: [email protected] <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312769}
Separate `SuggestionType::kAutofillOption`, depending on filling product
This is a preliminary CL:
We want to add a new metric which would be the fieldwise version of
`Autofill.KeyMetrics.FillingAcceptance`.
The new metric will log `SuggestionType` (i.e it will record filling
acceptance grouped by `SuggestionType`).
There are already various metrics which record approximately the same
thing, but for only part of the suggestion types. The new metric will
basically unify all these already existing metrics.
`SuggestionType::kAutofillOption` can mean 4 different things at the
same time, so splitting it is necessary for the new metric to be
meaningful.
Bug: 40274514
Change-Id: I6bfd65d228dd1fe59a2aa3357d189a58f6cc1c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598762
Reviewed-by: Adem Derinel <[email protected]>
Reviewed-by: Jan Keitel <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Theo Cristea <[email protected]>
Reviewed-by: Timofey Chudakov <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312768}
[iOS][PageInfo] Make UI flag enable/disable the master ATP feature
ATP fetching is only avaible if the master AboutThisPage feature is
enabled. This CL matches the state of the master ATP feature to the UI
feature flag.
Bug: none
Change-Id: I5a7da8166243f28ad4f52b621f03d18341a78dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614690
Auto-Submit: Filipa Senra <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Filipa Senra <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312767}
[Uno-D] Accepting signin interception sets ChromeSignin setting to always signin
Bug: b:345737884
Change-Id: Ib93005fda83e3de0b49fabc02ac13236f29c8a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5613298
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312766}
Update PdfOcrControllerTest.
Two disabled tests are updated and enabled and a new test is added for
SelectToSpeak.
AX-Relnotes: n/a
Bug: 341856144
Change-Id: I392e545b609a144798ce99f8a03ba7b73b92c158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5601477
Auto-Submit: Ramin Halavati <[email protected]>
Reviewed-by: Abigail Klein <[email protected]>
Commit-Queue: Abigail Klein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312765}
Add page handler and resources for Related Website Sets DevUI
Add WebUI controller and reference to resources directory for
related-website-sets.
Add routing for chrome://privacy-sandbox-internals/related-website-sets
Bug: 330877132
Change-Id: I4d35273570a68d79ea5cf9d08a6c229039533b65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5593094
Reviewed-by: Demetrios Papadopoulos <[email protected]>
Commit-Queue: Gabriel Tellez Ornelas <[email protected]>
Reviewed-by: Dylan Cutler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312764}
webrtc-internals: make somethingId clickable in stats tables
webrtc-stats follow a pattern where a property ending with "Id"
is a pointer to another object in the results. This way the stats
graph can be traversed. This CL adds support for webrtc-internals
to make these members clickable as (internal) hyperlinks
BUG=chromium:345091933
Change-Id: I45dd6eb66e3789cde0c2907e68659655472ae107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5599954
Reviewed-by: Harald Alvestrand <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Philipp Hancke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312763}
[iOS Blink] Support to remove //content/ from unsafe_bufers_paths.txt
https://crrev.com/c/5608913 missed adding UNSAFE_BUFFERS_BUILD
macro to child_process_bridge.mm file. This CL adds it to the
file to fix a build break.
Bug: 342213636
Change-Id: Ia39b68682b578cf3574eace272b83d7fc2cf9dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5611280
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312762}
[waffle]Fix crash when a policy disables the DSE
The `TemplateURLService::GetDefaultSearchProvider` function can return
`nullptr` if the DSE is disabled by the `DefaultSearchProviderEnabled`
policy for example.
The main reason of the crash was because we set the value of
`kDefaultSearchProviderGUID` to the value in
`kSyncedDefaultSearchProviderGUID` for migration. We did that in
`GetDefaultSearchProviderGuidFromPrefs` which triggers the pref
observer to react to the pref change and causes the crash.
Fixed: b:343391762
Change-Id: I05de527a4aadae32af1cff5eb86a477c9a907938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5577001
Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
Auto-Submit: Jack Yammine <[email protected]>
Commit-Queue: Jack Yammine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312761}
Run AttributionResolver unit tests using an in-memory database
For efficiency, since that class is meant to be agnostic to the
underlying storage mechanism.
We still have coverage for on-disk databases in AttributionStorageSql's
unit tests.
Performance on my machine before:
AttributionResolverTest.HandleSource_DestinationThrottleReportingLimitReached: 1040 ms
AttributionResolverTest.HandleSource_DestinationThrottleGlobalLimitReached: 5006 ms
AttributionResolverTest.HandleSource_DestinationThrottleBothLimitsReached: 5274 ms
After:
AttributionResolverTest.HandleSource_DestinationThrottleReportingLimitReached: 99 ms
AttributionResolverTest.HandleSource_DestinationThrottleGlobalLimitReached: 606 ms
AttributionResolverTest.HandleSource_DestinationThrottleBothLimitsReached: 724 ms
Bug: 343522089
Change-Id: Iabc02e9e52035f54841176c72ad40441b94ab343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5596493
Reviewed-by: Nan Lin <[email protected]>
Auto-Submit: Andrew Paseltiner <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312760}
[Tab Group Sync] Implement shared tab bridge remote updates
This CL adds a base implementation for remote updates (both the initial
sync and incremental). It does not implement dealing with tabs missing
tab groups and processing remote updates to tabs (only groups are
implemented).
Current CL uses raw specifics to store data to the storage. It will be
changed in future CLs to make it possible to store local-only data if
necessary. Tests currently don't verify that data is stored properly.
The implementation is copied over from the SavedTabGroup sync bridge
because it will likely have differences in the future (for example,
position processing). Once the bridge is implemented, it will be simpler
to find the code which can be shared (e.g. using some helpers).
Bug: 319521964
Change-Id: Ic6ba2e01ed56e4d0b18a31b238f48df572053ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598775
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312759}
diagnose_bloat.py: Add --arm64 flag and associated targets
When android-binary-size trybot reports large size increase in arm64
size, this can be used to create a size report.
Bug: None
Change-Id: I68c549f4ec1bba61cda82f4e5ceb0c0fdc423a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5608297
Owners-Override: Andrew Grieve <[email protected]>
Reviewed-by: Sam Maier <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312758}
Reland "[chromebox_for_meetings] Don't drop characters from lines"
This is a reland of commit 20281ac1dbab614b3d9c1a7fa5379efed7d44287
Original change's description:
> [chromebox_for_meetings] Don't drop characters from lines
>
> The GetCurrentOffset() function was written to support
> getting the current file offset, even if the file is at
> an EOF, which would normally cause tellg() to return -1.
> To handle the EOF case, we were performing the following
> routine: clear EOF bit -> tellg() -> .get() to re-trigger
> the EOF bit. It was falsely determined that the .get()
> call would be safe and not advance the read pointer, but
> in very specific cases, this causes some log lines to have
> their leading character dropped, which leads to a malformed
> timestamp and effectively drops the log.
>
> Instead of this hacky process, we can track the last known
> read offset in a member variable and treat it as the current
> offset when we've reached an EOF. This logic works because
> tellg() will only report a -1 *after* we attempt a read that
> contains no data; if we call tellg() after reading the last
> line, but before calling getline() again, it will report the
> correct offset.
>
> Bug: b:343965002
> Change-Id: Icd43161c3c1114302c88b1fbc151198be05674f4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5589844
> Auto-Submit: Niko Tsirakis <[email protected]>
> Reviewed-by: Kyle Williams <[email protected]>
> Commit-Queue: Kyle Williams <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1310785}
Bug: b:343965002
Change-Id: I448fd24cc8fa8d200a30bee8c5a34fc3c968b8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5602317
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Niko Tsirakis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312757}
Introduce GetAutoApprovalStatus method
This method introduced in permissions_client interface for better
readability of what is happening in the permissions_request_manager.
Bug: b/343010457
Change-Id: Ie863f6d88792708cbba269220e24e02898921a70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5600270
Reviewed-by: Sergii Bykov <[email protected]>
Reviewed-by: Ravjit Uppal <[email protected]>
Commit-Queue: Ashutosh Singhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312756}
[iOS] Fix contextMenuActionProviderForWebState crash
This CL removes the `CHECK` of the context menu title nullability. A
context menu can be triggered without having a title.
Bug: 345590010
Change-Id: I6a9f1ef5d11dc898f9279de1580c99111f81b4f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614311
Reviewed-by: Éric Noyau <[email protected]>
Commit-Queue: Elmehdi Rahmaoui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312755}
Update `TestExpectations` with bugs filed for crrev.com/c/5612692
[email protected]
Bug: 345868497, 345868498, 345868499, 346088868
Change-Id: I43bb9711b912fa10fda2a17f08698d5958f61446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614650
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312754}
build_rust.py: One more typo: 'idsir'
Bug: 343232416
Change-Id: I482fec258011dce19b0b8a9ae06973d1a56fe24b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614950
Auto-Submit: Hans Wennborg <[email protected]>
Commit-Queue: Hans Wennborg <[email protected]>
Commit-Queue: danakj <[email protected]>
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312753}
Roll ANGLE from 3a3b55f7ac9b to aa75d2f17dcf (2 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/3a3b55f7ac9b..aa75d2f17dcf
2024-06-10 [email protected] Roll Chromium from 87095b772157 to 2105b88a027e (849 revisions)
2024-06-10 [email protected] Roll VK-GL-CTS from d2d6aa656073 to 2329d7c1259e (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ia6e087cc1b279404abfbf1b56b1d9232f8551246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5613751
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312752}
[ozone/wayland] Fix text-input-v1 crash with ibus
When using text-input-v1 backend with ibus on KDE on entering text an
initial empty preedit_string event is received without any preceding
preedit_cursor event. This resulted in a composition text selection
being set with an InvalidRange() according to the previous logic.
However, SurroundingTextTracker is only designed to work with valid
ranges and ends up crashing due to an overflow.
This avoids the crash by setting the cursor location to the beginning of
composition text when such preedit_string events are received without a
preceding preedit_cursor or if explicit preedit_cursor events are
received with a negative value.
Bug: 40263583
Change-Id: I3340a85d500e5a9420105889ded82cf0c1e9a340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598518
Reviewed-by: Eriko Kurimoto <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Orko Garai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312751}
Split WaylandExtension into WaylandToplevelExtension
WaylandExtension currently only works for WaylandToplevelWindow. But, we
increasingly need to do synchronisation in tests on windows other than
top level windows. For example, bubbles are now separate UI compositors
in lacros.
This CL splits WaylandExtension into a WaylandExtension and
WaylandToplevelExtension. WaylandExtension is intended to work for
WaylandWindow and all its subclasses. WaylandToplevelExtension is
a sub-interface of WaylandExtension, but in order to avoid accidental
usage / wrong casts, this CL stores both WaylandExtension and
WaylandToplevelExtension in separate window properties.
Bug: None
Test: CQ
Change-Id: I570b1fc7e20b7070fbd1956a3bbf63930cdadfeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5547263
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Eliot Courtney <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312750}
[DevTools] Rename labels for UMA of resource type filters
DevTools CL: https://crrev.com/c/5604303
Bug: 40282893
Change-Id: If3f5846b3667480bc0e8ddf007b6bfbace96c817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5604422
Auto-Submit: Wolfgang Beyer <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312749}
[A11y] Add flag for feature to magnify magnifier confirmation dialog
Feature will be added separately.
Bug: b/335728537
AX-Relnotes: N/A
Change-Id: If5ce573868a77e94a5d2f339531878ec49229b22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5608612
Reviewed-by: Kyungjun Lee <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312748}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1717997600-f4830ee6a8e5b8aeece9f6427409ffc6e9e726b5-a6513f99609edc6da32ba9f0c74dbcf061a909ca.profdata to chrome-linux-main-1718020694-5460e76067dca10422f2501e78f95d700e946368-8003dfad08b6aefbd8447edfc2704e442f0c3bee.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I3f29b5865082f753062a3a7780987bab7f9efada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5613795
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312747}
Bump BiDi Mapper
Bug: chromedriver:4226
Change-Id: I3604e3f280d42d3e3edcf5e8cee0683c8d529708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614670
Reviewed-by: Vladimir Nechaev <[email protected]>
Commit-Queue: Maksim Sadym <[email protected]>
Commit-Queue: Vladimir Nechaev <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312746}
peerconnection: Implement EncoderStateObserverImpl
EncoderStateObserverImpl collects the encode stats for the top spatial
layer in SVC encoding, top stream in simulcast or the vanilla stream
otherwise. It doesn't collect stats if multiple encoders are running.
Bug: b:320555128
Test: encoder_state_observer_impl_test
Change-Id: I981025be0a57436b29958d50d9118bb59ae85377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5561085
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: Johannes Kron <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Mirko Bonadei <[email protected]>
Reviewed-by: Erik Språng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312745}
Update kDefaultLocalUpmMinGmsVersionForAuto to 241512000
This is required to avoid regressing automotive users since UPM M4 was enabled by default.
Bug: 325880829
Change-Id: I5a717bb6f789cc531954d321c1e6dfd337eefede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5611242
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312744}
Roll devtools-internal from 33f9eb36b5db to 6ac192f9df3b (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/33f9eb36b5db..6ac192f9df3b
Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/750b6328c7478496f24f40e03a3329f41842f122..25dbec176b26a11652c8946e9b489b01b11a9e03
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I2fbc9955ee96c152ee5776be3de8a28bc9bba4d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5613918
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1312743}
Test that URLs are recorded for SourceIdType::NOTIFICATION_ID.
This CL adds a regression test to ensure that for SourceIdType::NOTIFICATION_ID, the source is recorded along with the URL.
Change-Id: I9102fb787c684364aed170d7f573d83548353583
Fixed: 345709997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5613052
Auto-Submit: Balazs Engedy <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312742}
Reland "Update history sync screen buttons to follow minor mode restrictions"
This is a reland of commit c0ab209b23abd6009fc2ae625734ce728df47c0e
* This cl was reverted due to two tests in HistorySyncTest.java failing
on android auto. This is due to these tests being intended for the
portrait layout since the button IDs are different. This will be fixed
with b/345663992. For now these tests will be disabled on android auto.
Added the previously failing android auto trybot for verification. There
are additional tests which check the landscape layouts.
Original change's description:
> Update history sync screen buttons to follow minor mode restrictions
>
> * Updates the history sync buttons to be invisible until MinorModeHelper has resolved. Screenshots in bug.
>
> * When using the landscape layout buttons are created and added to the
> button bar. In portrait mode, a hidden button is shown.
>
> Bug: 338552074
> Change-Id: I48018ddb43360e8b46fa52f233a4dad45ab3f463
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5557826
> Commit-Queue: Liza Bipin <[email protected]>
> Code-Coverage: [email protected] <[email protected]>
> Reviewed-by: Boris Sazonov <[email protected]>
> Reviewed-by: Samar Chehade-Lepleux <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1311849}
Bug: 338552074
Change-Id: If0f302e9365add26dd9b363f4868feecdeb368bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5610695
Reviewed-by: Samar Chehade-Lepleux <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Commit-Queue: Liza Bipin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312741}
Updating XTBs based on .GRDs from branch main
Change-Id: I311d247ea74ccddb1810ffb5bc967924a76eda0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614390
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312740}
[OOBE] - Add metrics to the Personalized Onboarding screens
Add the following metrics:
Use-Case selection screen:
1) Loading step time
2) Amount of use-case selected
3) Percentage of use-case selected
4) Order IDs of selected use-cases
Recommend Apps screen:
1) Loading step time
2) Total amount of apps selected
3) Percentage of total apps selected
4) Amount of ARC apps selected
5) Percentage of ARC apps selected
6) Amount of Web apps selected
7) Percentage of Web apps selected
8) Order IDs of selected apps
Bug: b/331186139
Change-Id: I201be1e0ab0e89109d08d9000aa952fab17f9f91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5605728
Reviewed-by: Osama Fathy <[email protected]>
Commit-Queue: Bohdan Tyshchenko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312739}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1717961106-c9324f8d401b70bcfdf7a4abaa63902381f2e281-437b425fbb29e1946f049c67091ca3214cfd8280.profdata to chrome-android64-main-1718013550-ac80acec6d1779d82db6e061ac66b34164d316c3-84460240f68478b4968e7ea439c4c0933f494100.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I3dea1d7b60a0423db5e55442dafce387031ae1f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614191
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312738}
build_rust.py: Fix typo when deleting the build dir
Followup to crrev.com/c/5606683
Bug: 343232416
Change-Id: I8e74688a3681ae55ab0993de649076f35455a6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614052
Commit-Queue: danakj <[email protected]>
Reviewed-by: danakj <[email protected]>
Auto-Submit: Hans Wennborg <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312737}
Roll Perfetto from ade4bfc52243 to bee97a7c037d (3 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/ade4bfc52243..bee97a7c037d
2024-06-10 [email protected] ui: remove "service worker updated" popup
2024-06-10 [email protected] Merge "perfetto: fix swallowed exit code on Windows" into main
2024-06-10 [email protected] Merge "[Scroll Jank Plugin] Refactor scroll offset plot using Scroll ID" into main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Ifb74b1af3c58edfba78fde70987b19543558bf53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614071
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312736}
[Android] Add generic substring for re-fre
Bug: 329441982
Change-Id: I884998dd4c3509fc83c1aff0987bcd69afcbd83e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5576942
Auto-Submit: Tanmoy Mollik <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312735}
privacy-hub: Fix crash on NotifyGeolocationPermissionChanged() in Perso app
Personalization app would crash on system geolocation access level
changes. I could only reproduce this for users from a domain other than
Google. Apparently the Ambient mode is not yet allowed for the
enterprise domains. Thus the `PersonalizationAppAmbientProviderImpl`
would not bind the `ambient_observer_remote_` endpoint, which was
asserted in the `NotifyGeolocationPermissionChanged()`.
Modify this assertion with returning preemptively if the
`ambient_observer_remote_` endpoint is not bound.
Bug: b:344653836
Change-Id: I808581d60059b9e4303a36a32e194846dbf1b940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5610699
Commit-Queue: Zauri Meshveliani <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312734}
Roll Chrome Lacros Amd64 Generic PGO Profile
Roll Chrome Lacros Amd64 PGO profile from chrome-chromeos-amd64-generic-main-1717961106-5c7a94bc0e8bdf0f711a5abb5e98650c50533673-437b425fbb29e1946f049c67091ca3214cfd8280.profdata to chrome-chromeos-amd64-generic-main-1718020694-f5b5e2b4245f11aa40685ca8f56a48f94f3b15f2-8003dfad08b6aefbd8447edfc2704e442f0c3bee.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-lacros-amd64-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I8445d32dd3aa9e08c0157de1f3abcf6c6e1003aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614073
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312733}
Roll Perfetto Trace Processor Linux from 0c7c665c51d8 to ade4bfc52243
https://android.googlesource.com/platform/external/perfetto.git/+log/0c7c665c51d8..ade4bfc52243
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I0938167002361a2a6dbddd6333e45138225a0ca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5614250
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312732}
[ios] Fix Default Browser Banner in the FRE
This change sets the bannerSize property in the Default Browser view
just as the signin screen already does. Below are screenshots showing
the appearance after this change.
Signin Screen:
https://screenshot.googleplex.com/7myVjkzZNvpKd7d.png
Default Browser Screen:
https://screenshot.googleplex.com/4RPbCEaFcrSeimF.png
Fixed: 345507382
Change-Id: If637ef181bf5f92840672294e76cabd2ad25e7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5607827
Code-Coverage: [email protected] <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Scott Yoder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312731}
Refactor ClipboardOzone::GetSource
The issue in b/345214239 was caused because ClipboardOzone's source
tracking logic is only partially implemented on non-LaCrOS and
doesn't have any code to clear its source when data is copied from
outside the browser on Linux.
The issue is fixed by tracking the source URL within the clipboard
itself instead of using an internal data member in ClipboardOzone for
non-LaCrOS Linux, similarly to how ClipboardWin and ClipboardMac work.
For LaCrOS, instead the existing logic that serializes a
`DataTransferEndpoint` is kept, but without any internal data members.
Bug: b/345214239
Change-Id: I2cb753a4092851f1903d31025658a5d660d1fe2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598457
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312730}
Roll ios_internal from 83c95188777a to 7ea2d0506338
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/83c95188777a..7ea2d0506338
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ie9dcafcb3195c9a70759a909c9f7b166bad8fb66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5613916
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1312729}
WATCHLISTS: Remove PA watcher
Since (Google-internal) chrome-memory-tok was added back in 2021 [1], I
don't think we've actually seen a stream of CLs in PA's directories.
Whatever is responsible for ferrying Gerrit activity seems not to have
write permission for internal groups.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3129486
Change-Id: I3ce909d1e8c76c79711022c2d624f5d2b6bc3bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5601372
Reviewed-by: Mikihito Matsuura <[email protected]>
Commit-Queue: Kalvin Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1312728}